ipareplica: Don't rely on pkg_resources whenever possible

[rjeffman]

Python's module "pkg_resources" API has been deprecated in Python 3.12 and will be removed in a future release, and recent FreeIPA versions provide a replacement for pkg_resources.parse_version.

To remove ansible-freeipa dependency on pkg_resources and not add a dependency on the 'packaging' module, which is not available in the standard Python distribution, we'll try to import the funcion used in FreeIPA to parse versions, and fallback to pkg_resources when it fails.

As an equivalent class is needed, a fallback function is not provided and execution will fail if neither the FreeIPA nor the pkg_resources parse_version function are available.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the ansible_ipa_replica.py module to avoid direct dependency on the pkg_resources module, which is deprecated in Python 3.12. It attempts to import parse_version from ipapython.version first, and falls back to pkg_resources only if the former is not available. If neither is available, an exception is raised.

Updated class diagram for version parsing

classDiagram
    class ansible_ipa_replica {
        +getargspec(func)
    }
    note for ansible_ipa_replica "Tries to import parse_version from ipapython.version, falls back to pkg_resources if unavailable."

Loading

File-Level Changes

Change	Details	Files
Import parse_version from ipapython.version and fallback to pkg_resources if it's not available.	Added a try-except block to import parse_version from ipapython.version. If the import fails, fall back to importing parse_version from pkg_resources. If neither import succeeds, let the exception be raised.	roles/ipareplica/module_utils/ansible_ipa_replica.py
Removed direct import of parse_version from pkg_resources.	Removed the line that directly imports parse_version from pkg_resources.	roles/ipareplica/module_utils/ansible_ipa_replica.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rjeffman - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a comment explaining why pkg_resources is still imported in the except block.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[varunmylaraiah]

The PR changes look good and do not affect the existing tests. All existing test suites have passed with these changes

[t-woerner]

LGTM