Modify for scp #52
Draft
Modify for scp #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy89923
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Hi @mamie1031 ,
Thanks for the PR!
Please fix the linter error, thanks~
andy89923
reviewed
Jan 23, 2025
andy89923
reviewed
Feb 2, 2025
andy89923
reviewed
Feb 4, 2025
Comment on lines
+478
to
+479
| if nfProfile.NfType == models.NfType_SCP && len(nfProfile.Ipv4Addresses) > 0 { | ||
| if len(nfProfile.Ipv4Addresses[0]) > 0 { |
There was a problem hiding this comment.
These two conditions can be merged to one if.
Comment on lines
+515
to
+516
| if nfProfile.NfType == models.NfType_SCP && len(nfProfile.Ipv4Addresses) > 0 { | ||
| if len(nfProfile.Ipv4Addresses[0]) > 0 { |
There was a problem hiding this comment.
These two conditions can be merged into one if.
| @@ -320,6 +320,10 @@ func (p *Processor) NFDeregisterProcedure(nfInstanceID string) *models.ProblemDe | |||
| logger.NfmLog.Warningf("Can not delete NFCertPem file: %v: %v", nfCertPath, removeErr) | |||
| } | |||
| } | |||
| // Set SCP to unable | |||
There was a problem hiding this comment.
Suggested change
| // Set SCP to unable | |
| // Set SCP to disable |
Comment on lines
+481
to
+482
| ScpIp := nfProfile.Ipv4Addresses[0] | ||
| ScpUri := "http://" + ScpIp + ":8000" // default port |
There was a problem hiding this comment.
Please check ScpInfo in NFProfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have revised my project and the way of merging. If there are any issues, let me know!🙌