Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show attendance w.r.t years instead of academic year #218

Conversation

RitvikSardana
Copy link
Member

Currently:
Screenshot 2024-03-12 at 12 43 06 PM

In the report "Student Monthly Attendance Sheet"

we select "academic year" and a month, and then in code we take the year_start_date from the academic year.
Which gives us incorrect data

For e.g.

The attendance is marked on 2024 March, but the academic year is 2023-2024 which starts from "April 23" and end on "March 24"

So instead of taking 'March Year 24', current code will take 'March Year 23' .

Solution
Screenshot 2024-03-12 at 12 48 01 PM

Ask for Year instead of Academic Year in the filters.

@RitvikSardana RitvikSardana merged commit 8bf99ed into frappe:develop Mar 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant