fix: show attendance w.r.t years instead of academic year #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: remove translations from hooks.py
RitvikSardana
force-pushed
the
develop-ritvik-attendance-year
branch
from
bf5596a to
e719af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently:
In the report "Student Monthly Attendance Sheet"
we select "academic year" and a month, and then in code we take the year_start_date from the academic year.
Which gives us incorrect data
For e.g.
The attendance is marked on 2024 March, but the academic year is 2023-2024 which starts from "April 23" and end on "March 24"
So instead of taking 'March Year 24', current code will take 'March Year 23' .
Solution
Ask for Year instead of Academic Year in the filters.