From 3aac19ce479e4642433cf13d9071ce2bad250248 Mon Sep 17 00:00:00 2001 From: Norman Xu Date: Fri, 24 Jan 2025 16:19:04 +0000 Subject: [PATCH] feat: expose onSignature related callbacks for eth_signTypedData_v4 request --- .changeset/strange-oranges-count.md | 5 +++++ packages/render/src/types.ts | 3 +++ packages/render/src/unstable-types.ts | 3 +++ packages/render/src/unstable-use-frame.tsx | 6 ++++++ packages/render/src/use-frame.tsx | 17 +++++++++++++---- 5 files changed, 30 insertions(+), 4 deletions(-) create mode 100644 .changeset/strange-oranges-count.md diff --git a/.changeset/strange-oranges-count.md b/.changeset/strange-oranges-count.md new file mode 100644 index 000000000..4aa4cddf8 --- /dev/null +++ b/.changeset/strange-oranges-count.md @@ -0,0 +1,5 @@ +--- +"@frames.js/render": patch +--- + +feat: expose onSignature callbacks for eth_signTypedData request from server diff --git a/packages/render/src/types.ts b/packages/render/src/types.ts index dd798f736..a1701a5ad 100644 --- a/packages/render/src/types.ts +++ b/packages/render/src/types.ts @@ -281,6 +281,9 @@ export type UseFrameOptions< | "onTransactionError" | "onTransactionStart" | "onTransactionSuccess" + | "onSignatureError" + | "onSignatureStart" + | "onSignatureSuccess" | "onTransactionProcessingError" | "onTransactionProcessingStart" | "onTransactionProcessingSuccess" diff --git a/packages/render/src/unstable-types.ts b/packages/render/src/unstable-types.ts index a65d7c1c4..412e6a87f 100644 --- a/packages/render/src/unstable-types.ts +++ b/packages/render/src/unstable-types.ts @@ -211,6 +211,9 @@ export type UseFrameOptions< | "onTransactionError" | "onTransactionStart" | "onTransactionSuccess" + | "onSignatureError" + | "onSignatureStart" + | "onSignatureSuccess" | "onTransactionProcessingError" | "onTransactionProcessingStart" | "onTransactionProcessingSuccess" diff --git a/packages/render/src/unstable-use-frame.tsx b/packages/render/src/unstable-use-frame.tsx index 6d4a4592e..8f11ade81 100644 --- a/packages/render/src/unstable-use-frame.tsx +++ b/packages/render/src/unstable-use-frame.tsx @@ -186,6 +186,9 @@ export function useFrame_unstable< onTransactionError, onTransactionStart, onTransactionSuccess, + onSignatureError, + onSignatureStart, + onSignatureSuccess, onTransactionProcessingError, onTransactionProcessingStart, onTransactionProcessingSuccess, @@ -235,6 +238,9 @@ export function useFrame_unstable< onTransactionError, onTransactionStart, onTransactionSuccess, + onSignatureError, + onSignatureStart, + onSignatureSuccess, onTransactionProcessingError, onTransactionProcessingStart, onTransactionProcessingSuccess, diff --git a/packages/render/src/use-frame.tsx b/packages/render/src/use-frame.tsx index dedafe433..10273ea3d 100644 --- a/packages/render/src/use-frame.tsx +++ b/packages/render/src/use-frame.tsx @@ -183,11 +183,14 @@ export function useFrame< onTransactionDataStart, onTransactionDataSuccess, onTransactionError, + onTransactionStart, + onTransactionSuccess, + onSignatureError, + onSignatureStart, + onSignatureSuccess, onTransactionProcessingError, onTransactionProcessingStart, onTransactionProcessingSuccess, - onTransactionStart, - onTransactionSuccess, }: UseFrameOptions< TSignerStorageType, TFrameActionBodyType, @@ -231,11 +234,14 @@ export function useFrame< onTransactionDataStart, onTransactionDataSuccess, onTransactionError, + onTransactionStart, + onTransactionSuccess, + onSignatureError, + onSignatureStart, + onSignatureSuccess, onTransactionProcessingError, onTransactionProcessingStart, onTransactionProcessingSuccess, - onTransactionStart, - onTransactionSuccess, }); const fetchFrameRef = useFreshRef(fetchFrame); @@ -325,6 +331,7 @@ export function useFrame< homeframeUrl, signerState.hasSigner, signerState.signer, + onErrorRef, ] ); @@ -395,6 +402,7 @@ export function useFrame< connectedAddress, homeframeUrl, signerState, + onErrorRef, ] ); @@ -516,6 +524,7 @@ export function useFrame< onPostButton, onTransactionButton, signerState, + onErrorRef, ] );