-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CMS Starter example #134
base: main
Are you sure you want to change the base?
Conversation
ce26e37
to
fc608ad
Compare
fc608ad
to
36e36fc
Compare
36e36fc
to
354b9f5
Compare
Signed-off-by: Cédric Boirard <cedric@framer.com>
Signed-off-by: Cédric Boirard <cedric@framer.com>
64eda3c
to
405e0df
Compare
4104a2f
to
ba7fd80
Compare
ba7fd80
to
d5d0288
Compare
Signed-off-by: Cédric Boirard <cedric@framer.com>
d5d0288
to
80d249f
Compare
- Chore Signed-off-by: Cédric Boirard <cedric@framer.com>
Lets call the actual folder "cms" instead of "cms-starter" since its already in a folder called "examples" |
userEditable: false, | ||
}) | ||
break | ||
case "string": | ||
case "number": | ||
case "boolean": | ||
case "color": | ||
case "formattedText": | ||
fields.push({ | ||
id: fieldId, | ||
name: fieldId, | ||
type: field.type, | ||
userEditable: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
userEditable
is optional and something we are probably going to deprecate, shall we just not include it in the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not optional yet:
/**
* Any kind of collection field definition that was created by a plugin and is
* supported by the API.
*/
type ManagedCollectionField = SupportedCollectionField & {
/** Is the user able to edit the field within the UI. */
userEditable: boolean;
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no. Let's make it optional ASAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhhh, actually, I think we should use the type
export type EditableManagedCollectionField = SupportedCollectionField &
Partial<Pick<ManagedCollectionField, "userEditable">>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is not exported by framer-plugin
Because there is only a single plain text field its impossible to QA if the slug field selector works as expected when there are multiple options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last few details. Getting really close now. Great work 👏
.no-scrollbar::-webkit-scrollbar { | ||
display: none; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets move this into framer.css as "framer-hide-scrollbar"
[data-framer-theme="light"] .scroll-fade { | ||
background: linear-gradient(to bottom, transparent, white); | ||
} | ||
|
||
[data-framer-theme="dark"] .scroll-fade { | ||
background: linear-gradient(180deg, rgba(18, 18, 18, 0) 0%, rgb(17, 17, 17) 97.8%); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
into framer.css as "framer-scroll-fade-vertical"
.mapping footer::before { | ||
content: ""; | ||
position: absolute; | ||
top: -45px; | ||
left: 0; | ||
width: 100%; | ||
height: 45px; | ||
background: linear-gradient(to bottom, transparent, var(--framer-color-bg)); | ||
pointer-events: none; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no, this is the one in use not the .scroll-fade
11826bb
to
54abe15
Compare
@jonastreub fixed this by making it a real button (will benefit of accessibility too)
I added a new plain text field to categories! |
54abe15
to
9d893ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those were the last few nits code wise. Stellar work 👏
Just QA'd and it works flawlessly now ❤️ |
9d893ad
to
953e5a4
Compare
Signed-off-by: Cédric Boirard <cedric@framer.com>
cc @huntercaron using |
Description
This pull request introduces a new CMS starter example, including updates to various configuration files, data sources, and UI components. The changes aim to set up a basic CMS plugin for Framer, providing a template for further development.
QA
examples/cms
directory.Additional Checks