refactor(core): enhance cancel_abort logic with return value and retr… #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y handling The commit modifies the `shards_cancel_abort` function to return a boolean indicating whether the abort was successfully canceled. This change is propagated to the Rust bindings and used in HTTP request retry logic to handle cases where the wire might have been aborted, preventing unnecessary retries.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #1105 +/- ##
==========================================
- Coverage 80.99% 80.98% -0.02%
==========================================
Files 359 359
Lines 62422 62426 +4
==========================================
- Hits 50561 50557 -4
- Misses 11861 11869 +8 ☔ View full report in Codecov by Sentry. |
Replace assertions with runtime error throws in BaseRunner::compose and BaseRunner::warmup to handle missing wire cases more gracefully. This ensures better error handling and debugging information when the wire is not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y handling
The commit modifies the
shards_cancel_abortfunction to return a boolean indicating whether the abort was successfully canceled. This change is propagated to the Rust bindings and used in HTTP request retry logic to handle cases where the wire might have been aborted, preventing unnecessary retries.