Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review sudo/SLURM executor and its tests #2246

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Review sudo/SLURM executor and its tests #2246

merged 7 commits into from
Feb 4, 2025

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Feb 4, 2025

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@tcompa tcompa marked this pull request as ready for review February 4, 2025 12:42
Copy link

github-actions bot commented Feb 4, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.9 9.3 1.06 0.6 0.6
power 364.0 372.1 0.98 345.4 345.4
dataset 126.1 135.2 0.93 123.2 123.2
project 39.3 40.7 0.97 43.9 43.9
job 22.2 22.3 1.00 29.7 29.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.1 6.2 0.98 2.2 2.2
power 125.9 131.6 0.96 662.2 662.2
dataset 129.8 132.2 0.98 915.2 915.2
project 42.1 44.9 0.94 286.9 286.9
job 36.9 38.0 0.97 227.4 227.4

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.0 7.7 0.91 0.1 0.1
power 7.3 7.5 0.97 0.1 0.1
dataset 7.4 6.8 1.09 0.1 0.1
project 8.7 8.6 1.01 2.3 2.3
job 6.9 7.0 0.99 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.9 6.5 0.91 0.8 0.8
power 5.6 6.6 0.85 0.8 0.8
dataset 5.5 6.3 0.87 0.8 0.8
project 5.8 6.5 0.89 0.8 0.8
job 5.4 5.8 0.93 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.1 7.2 0.99 1.6 1.6
power 6.6 7.4 0.89 1.6 1.6
dataset 6.6 7.4 0.89 1.6 1.6
project 6.6 8.1 0.81 1.6 1.6
job 6.7 7.7 0.87 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.4 12.6 0.83 0.8 0.8
power 22.3 23.3 0.96 28.0 28.0
dataset 17.1 18.1 0.94 16.2 16.2
project 19.8 20.6 0.96 20.4 20.4
job 10.2 10.4 0.98 0.8 0.8

POST /api/v2/project/3/dataset/412/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 134.4 135.2 0.99 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.5 4.8 0.94 0.2 0.2
power 4.7 4.4 1.07 0.2 0.2
dataset 4.8 4.5 1.07 0.2 0.2
project 4.8 4.6 1.04 0.2 0.2
job 4.6 4.7 0.98 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 273.5 274.3 1.00 0.2 0.2

Copy link

github-actions bot commented Feb 4, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/runner/executors/slurm/ssh
  executor.py 898-902, 997, 1064-1065
  fractal_server/app/runner/executors/slurm/sudo
  executor.py 923-924
  fractal_server/app/runner/v2/_local_experimental
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa requested a review from mfranzon February 4, 2025 15:05
@tcompa tcompa merged commit e71d69a into main Feb 4, 2025
20 checks passed
@tcompa tcompa deleted the executor-cleanup branch February 4, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants