Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review email configuration #2241

Merged
merged 29 commits into from
Feb 4, 2025
Merged

Review email configuration #2241

merged 29 commits into from
Feb 4, 2025

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Feb 3, 2025

closes #2224

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Feb 3, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Feb 3, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.7 9.9 0.98 0.6 0.6
power 359.8 364.0 0.99 345.4 345.4
dataset 128.8 126.1 1.02 123.2 123.2
project 37.3 39.3 0.95 43.9 43.9
job 25.9 22.2 1.17 29.7 29.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.5 6.1 1.07 2.2 2.2
power 128.0 125.9 1.02 662.2 662.2
dataset 127.8 129.8 0.98 915.2 915.2
project 43.9 42.1 1.04 286.9 286.9
job 34.8 36.9 0.94 227.4 227.4

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.9 7.0 0.99 0.1 0.1
power 6.7 7.3 0.92 0.1 0.1
dataset 6.7 7.4 0.91 0.1 0.1
project 9.0 8.7 1.03 2.3 2.3
job 7.5 6.9 1.09 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.1 5.9 1.03 0.8 0.8
power 6.0 5.6 1.07 0.8 0.8
dataset 5.6 5.5 1.02 0.8 0.8
project 5.8 5.8 1.00 0.8 0.8
job 6.1 5.4 1.13 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.3 7.1 1.03 1.6 1.6
power 6.8 6.6 1.03 1.6 1.6
dataset 6.6 6.6 1.00 1.6 1.6
project 6.6 6.6 1.00 1.6 1.6
job 6.8 6.7 1.01 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.6 10.4 1.02 0.8 0.8
power 22.3 22.3 1.00 28.0 28.0
dataset 17.3 17.1 1.01 16.2 16.2
project 22.8 19.8 1.15 20.4 20.4
job 10.6 10.2 1.04 0.8 0.8

POST /api/v2/project/3/dataset/412/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 138.1 134.4 1.03 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.5 4.5 1.00 0.2 0.2
power 4.3 4.7 0.91 0.2 0.2
dataset 4.3 4.8 0.90 0.2 0.2
project 4.3 4.8 0.90 0.2 0.2
job 4.3 4.6 0.93 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 274.0 273.5 1.00 0.2 0.2

Copy link

github-actions bot commented Feb 3, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  config.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
  fractal_server/app/runner/v2/_local_experimental
  executor.py
  fractal_server/app/security
  signup_email.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa

This comment was marked as resolved.

@ychiucco ychiucco requested review from tcompa and mfranzon and removed request for mfranzon February 4, 2025 09:11
fractal_server/__main__.py Outdated Show resolved Hide resolved
fractal_server/__main__.py Outdated Show resolved Hide resolved
fractal_server/config.py Outdated Show resolved Hide resolved
fractal_server/config.py Outdated Show resolved Hide resolved
fractal_server/config.py Outdated Show resolved Hide resolved
fractal_server/config.py Outdated Show resolved Hide resolved
fractal_server/config.py Outdated Show resolved Hide resolved
fractal_server/config.py Outdated Show resolved Hide resolved
fractal_server/config.py Outdated Show resolved Hide resolved
fractal_server/config.py Outdated Show resolved Hide resolved
@tcompa tcompa marked this pull request as ready for review February 4, 2025 15:32
@tcompa tcompa merged commit a5afca6 into main Feb 4, 2025
19 checks passed
@tcompa tcompa deleted the 2224-review-email-configuration branch February 4, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review email configuration
2 participants