Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove run_migrations_offline, make run_migrations_online sync #2239

Merged
merged 10 commits into from
Feb 4, 2025

Conversation

mfranzon
Copy link
Collaborator

@mfranzon mfranzon commented Feb 3, 2025

close #2234

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@mfranzon mfranzon linked an issue Feb 3, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Feb 3, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.0 9.2 1.20 0.6 0.6
power 393.8 352.3 1.12 345.4 345.4
dataset 143.2 123.8 1.16 123.2 123.2
project 45.7 37.7 1.21 43.9 43.9
job 25.3 22.0 1.15 29.7 29.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.0 6.0 1.33 2.2 2.2
power 135.9 123.1 1.10 662.2 662.2
dataset 142.1 127.1 1.12 915.2 915.2
project 47.9 42.0 1.14 286.9 286.9
job 43.3 36.5 1.19 227.4 227.4

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.6 7.7 1.12 0.1 0.1
power 8.2 7.4 1.11 0.1 0.1
dataset 8.2 7.4 1.11 0.1 0.1
project 10.2 8.5 1.20 2.3 2.3
job 7.9 7.3 1.08 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.8 6.1 1.11 0.8 0.8
power 6.6 5.9 1.12 0.8 0.8
dataset 6.8 5.9 1.15 0.8 0.8
project 7.2 6.2 1.16 0.8 0.8
job 6.6 5.9 1.12 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.4 7.2 1.17 1.6 1.6
power 8.2 7.1 1.15 1.6 1.6
dataset 8.0 7.1 1.13 1.6 1.6
project 7.9 7.1 1.11 1.6 1.6
job 7.7 6.9 1.12 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 13.1 10.8 1.21 0.8 0.8
power 25.5 23.0 1.11 28.0 28.0
dataset 19.6 17.9 1.09 16.2 16.2
project 23.0 20.2 1.14 20.4 20.4
job 12.2 11.3 1.08 0.8 0.8

POST /api/v2/project/3/dataset/417/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 147.3 132.5 1.11 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.8 4.4 1.09 0.2 0.2
power 4.5 4.3 1.05 0.2 0.2
dataset 5.0 4.4 1.14 0.2 0.2
project 4.9 4.2 1.17 0.2 0.2
job 4.9 4.3 1.14 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 274.2 272.1 1.01 0.2 0.2

Copy link

github-actions bot commented Feb 3, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

@tcompa tcompa merged commit a4d3dc5 into main Feb 4, 2025
@tcompa tcompa deleted the 2234-simplify-envpy branch February 4, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify env.py
2 participants