Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database updates post 2.11 #2232

Merged
merged 10 commits into from
Jan 30, 2025
Merged

Database updates post 2.11 #2232

merged 10 commits into from
Jan 30, 2025

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Jan 29, 2025

closes #2177

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Jan 29, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jan 29, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.0 9.5 1.05 0.6 0.6
power 366.4 367.2 1.00 345.4 345.4
dataset 131.8 134.9 0.98 123.2 123.2
project 37.8 39.1 0.97 43.9 43.9
job 22.8 26.4 0.86 29.7 29.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.5 6.9 0.94 2.2 2.2
power 124.8 126.4 0.99 662.2 662.2
dataset 129.2 135.6 0.95 915.2 915.2
project 42.8 44.8 0.96 286.9 286.9
job 37.2 38.5 0.97 227.4 227.4

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.0 7.6 0.92 0.1 0.1
power 6.7 7.0 0.96 0.1 0.1
dataset 6.8 7.0 0.97 0.1 0.1
project 8.7 8.7 1.00 2.3 2.3
job 7.0 7.5 0.93 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.8 6.0 0.97 0.8 0.8
power 5.6 5.8 0.97 0.8 0.8
dataset 5.6 6.3 0.89 0.8 0.8
project 5.9 6.7 0.88 0.8 0.8
job 5.6 6.2 0.90 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.1 7.5 0.95 1.6 1.6
power 7.3 7.1 1.03 1.6 1.6
dataset 6.6 7.0 0.94 1.6 1.6
project 6.9 6.9 1.00 1.6 1.6
job 6.8 7.2 0.94 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.7 11.7 0.91 0.8 0.8
power 22.6 24.5 0.92 28.0 28.0
dataset 18.1 19.0 0.95 16.2 16.2
project 20.9 21.2 0.99 20.4 20.4
job 11.3 11.8 0.96 0.8 0.8

POST /api/v2/project/3/dataset/417/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 136.0 138.4 0.98 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.8 4.6 1.04 0.2 0.2
power 4.6 4.4 1.05 0.2 0.2
dataset 4.6 4.4 1.05 0.2 0.2
project 4.6 4.4 1.05 0.2 0.2
job 4.5 4.4 1.02 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 274.0 274.3 1.00 0.2 0.2

@ychiucco ychiucco requested a review from tcompa January 30, 2025 13:52
@ychiucco ychiucco marked this pull request as ready for review January 30, 2025 13:53
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/models/v2
  dataset.py
  workflowtask.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa merged commit e3681d2 into main Jan 30, 2025
@tcompa tcompa deleted the 2177-database-updates-post-2110 branch January 30, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database updates post 2.11.0
2 participants