Deprecate V1 (db tables, API, runner) #2230

tcompa · 2025-01-29T10:38:02Z

Checklist before merging

I added an appropriate entry to CHANGELOG.md
I added logging to new code - if appropriate.
I merged main into the current branch.

github-actions · 2025-01-29T10:50:45Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)
fractal_server
__init__.py	$This PR doesn't change the number of statements in fractal_server/__init__.py, which is 1.$	$This PR doesn't change the number of statements missing coverage in fractal_server/__init__.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/__init__.py, which is 100% (1/1).$	$In this PR, 1 new statements are added to fractal_server/__init__.py, 1 of which are covered (100%).$
config.py	$This PR removes 4 from the number of statements in fractal_server/config.py, taking it from 286 to 282.$	$This PR doesn't change the number of statements missing coverage in fractal_server/config.py, which is 6.$	$This PR removes 0.04 percentage points from the coverage rate in fractal_server/config.py, taking it from 96.23% (280/286) to 96.19% (276/282).$	$This PR does not seem to add statements to fractal_server/config.py.$
main.py	$This PR removes 7 from the number of statements in fractal_server/main.py, taking it from 72 to 65.$	$This PR doesn't change the number of statements missing coverage in fractal_server/main.py, which is 1.$	$This PR adds 0.90 percentage points to the coverage rate in fractal_server/main.py, taking it from 96.42% (71/72) to 97.33% (64/65).$	$This PR does not seem to add statements to fractal_server/main.py.$
string_tools.py	$This PR removes 2 from the number of statements in fractal_server/string_tools.py, taking it from 19 to 17.$	$This PR doesn't change the number of statements missing coverage in fractal_server/string_tools.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/string_tools.py, which is 100% (17/17).$	$This PR does not seem to add statements to fractal_server/string_tools.py.$
fractal_server/app/models
__init__.py	$This PR removes 2 from the number of statements in fractal_server/app/models/__init__.py, taking it from 7 to 5.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/models/__init__.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/models/__init__.py, which is 100% (5/5).$	$This PR does not seem to add statements to fractal_server/app/models/__init__.py.$
linkuserproject.py	$This PR removes 3 from the number of statements in fractal_server/app/models/linkuserproject.py, taking it from 8 to 5.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/models/linkuserproject.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/models/linkuserproject.py, which is 100% (5/5).$	$This PR does not seem to add statements to fractal_server/app/models/linkuserproject.py.$
fractal_server/app/routes/aux
_job.py	$This PR removes 2 from the number of statements in fractal_server/app/routes/aux/_job.py, taking it from 9 to 7.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/aux/_job.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/aux/_job.py, which is 100% (7/7).$	$This PR does not seem to add statements to fractal_server/app/routes/aux/_job.py.$
fractal_server/app/runner
filenames.py	$This PR removes 2 from the number of statements in fractal_server/app/runner/filenames.py, taking it from 4 to 2.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/runner/filenames.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/runner/filenames.py, which is 100% (2/2).$	$This PR does not seem to add statements to fractal_server/app/runner/filenames.py.$
shutdown.py	$This PR removes 12 from the number of statements in fractal_server/app/runner/shutdown.py, taking it from 46 to 34.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/runner/shutdown.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/runner/shutdown.py, which is 100% (34/34).$	$This PR does not seem to add statements to fractal_server/app/runner/shutdown.py.$
fractal_server/app/runner/executors/slurm/ssh
executor.py	$This PR adds 1 to the number of statements in fractal_server/app/runner/executors/slurm/ssh/executor.py, taking it from 537 to 538.$	$This PR removes 1 from the number of statements missing coverage in fractal_server/app/runner/executors/slurm/ssh/executor.py, taking it from 108 to 107.$	$This PR adds 0.26 percentage points to the coverage rate in fractal_server/app/runner/executors/slurm/ssh/executor.py, taking it from 76.01% (429/537) to 76.27% (431/538).$	$This PR does not seem to add statements to fractal_server/app/runner/executors/slurm/ssh/executor.py.$
fractal_server/app/runner/executors/slurm/sudo
executor.py	$This PR removes 2 from the number of statements in fractal_server/app/runner/executors/slurm/sudo/executor.py, taking it from 437 to 435.$	$This PR adds 15 to the number of statements missing coverage in fractal_server/app/runner/executors/slurm/sudo/executor.py, taking it from 53 to 68.$	$This PR removes 3.46 percentage points from the coverage rate in fractal_server/app/runner/executors/slurm/sudo/executor.py, taking it from 85.76% (384/437) to 82.3% (367/435).$	$This PR does not seem to add statements to fractal_server/app/runner/executors/slurm/sudo/executor.py.$
fractal_server/app/runner/v2/_local
executor.py	$This PR doesn't change the number of statements in fractal_server/app/runner/v2/_local/executor.py, which is 26.$	$This PR removes 1 from the number of statements missing coverage in fractal_server/app/runner/v2/_local/executor.py, taking it from 1 to 0.$	$This PR adds 8.82 percentage points to the coverage rate in fractal_server/app/runner/v2/_local/executor.py, taking it from 91.17% (25/26) to 100% (26/26).$	$This PR does not seem to add statements to fractal_server/app/runner/v2/_local/executor.py.$
fractal_server/app/runner/v2/_local_experimental
executor.py	$This PR doesn't change the number of statements in fractal_server/app/runner/v2/_local_experimental/executor.py, which is 74.$	$This PR removes 1 from the number of statements missing coverage in fractal_server/app/runner/v2/_local_experimental/executor.py, taking it from 1 to 0.$	$This PR adds 2.22 percentage points to the coverage rate in fractal_server/app/runner/v2/_local_experimental/executor.py, taking it from 95.55% (73/74) to 97.77% (74/74).$	$This PR does not seem to add statements to fractal_server/app/runner/v2/_local_experimental/executor.py.$
fractal_server/app/schemas
_validators.py	$This PR removes 8 from the number of statements in fractal_server/app/schemas/_validators.py, taking it from 59 to 51.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/_validators.py, which is 0.$	$This PR removes 0.16 percentage points from the coverage rate in fractal_server/app/schemas/_validators.py, taking it from 98.92% (59/59) to 98.76% (51/51).$	$This PR does not seem to add statements to fractal_server/app/schemas/_validators.py.$
fractal_server/tasks
utils.py	$This PR removes 16 from the number of statements in fractal_server/tasks/utils.py, taking it from 23 to 7.$	$This PR doesn't change the number of statements missing coverage in fractal_server/tasks/utils.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/tasks/utils.py, which is 100% (7/7).$	$This PR does not seem to add statements to fractal_server/tasks/utils.py.$
Project Total

_{This report was generated by python-coverage-comment-action}

…in SSH/SLURM executor

…k is a parallel one

…cutionError` [close #2238]

This reverts commit 9eb5b6d.

…w_JobExecutionError` [close #2238]" This reverts commit 5d8490c.

Remove v1 tests for coverage

f90d0b7

tcompa linked an issue Jan 29, 2025 that may be closed by this pull request

Deprecate V1 API and runner #2229

Closed

This comment was marked as off-topic.

Sign in to view

tcompa added 3 commits January 29, 2025 11:45

Skip flaky test [skip ci]

c3730b1

Fix pytest.mark.skip [skip ci]

302e05f

.gitignore [skip ci]

4bd1f44

tcompa added 23 commits January 29, 2025 11:54

Drop tests_v1 CI job

af19c42

Add --omit "*v1*"

eee58db

Use --omit "**/*v1*"

6d7d921

Drop all v1 code from fractal-server

a47d0b6

Do not omit v1 code from coverage

fb8bbfb

Remove v1 code from tests

8b13aca

Remove some more v1 code from fractal-server

74691a4

Remove some more v1 code from tests

b27d2c7

Remove some more v1 code from fractal-server

e110d6e

Remove FRACTAL_API_SUBMIT_RATE_LIMIT

e049e14

Drop LinkUserProject

1b0099c

Add schema-migration script that drops v1 tables

6594b3c

Drop some more V1 from fractal-server

6db5659

Drop some more V1 from tests

0f917c7

Restore all V1 models

3e1c9d7

Restore V1 schemas

95d668c

Remove all non-primary columns from v1 tables / models

2057944

Remove all non-primary columns from v1 tables / migration script

8b65a8c

Drop V1 tables / models

cdd480e

Drop V1 tables / migration

060ec71

Remove V1 schemas

5533433

Remove drop-v1 migration

cdfa486

Remove LinkUserProject model

0095dc1

tcompa temporarily deployed to pypi January 31, 2025 08:30 — with GitHub Actions Inactive

tcompa changed the title ~~[DO NOT MERGE] Deprecate V1 API and runner~~ Deprecate V1 (db tables, API, runner) Jan 31, 2025

tcompa added 7 commits January 31, 2025 12:02

Drop get_collection_path function

fd687b8

Drop valint validator

9630467

Add test_UserSettingsUpdateStrict

df486c9

Add tests/v2/04_runner/test_unit_slurm_config.py

f35bd49

Remove v1 branch about _COMPONENT_KEY_ from sudo/ssh slurm runners

8a5f11a

Add tests/v2/04_runner/test_unit_fractal_thread_pool_executor.py

ff46d9e

Partly revert 8a5f11a, re-adding broad support for _COMPONENT_KEY_ …

c70221a

…in SSH/SLURM executor

tcompa mentioned this pull request Jan 31, 2025

Add Dynamic Context to coverage run/report #2236

Closed

tcompa added 6 commits January 31, 2025 14:59

Use WARNING in fractal-tasks-mock generic_task

ca597b6

Import fractal-tasks-mock from generic_task

4481c10

Import fractal-tasks-mock from some more tasks

ab538a3

Add sleep_time to generic parallel task

d50d953

Update test_failing_workflow_JobExecutionError so that the failed tas…

ec1a8c8

…k is a parallel one

FIXMEs and CHANGELOG [skip ci]

6e80558

tcompa marked this pull request as ready for review February 3, 2025 07:34

tcompa added 6 commits February 3, 2025 08:40

Merge branch 'main' into 2229-deprecate-v1-api-and-runner

bc0b50c

Add test_slurm_batching

ddf5f07

Improve test

a191ce7

Merge branch 'main' into 2229-deprecate-v1-api-and-runner

ac625fb

Improve `test_full_workflow_slurm_v2.py::test_failing_workflow_JobExe…

5d8490c

…cutionError` [close #2238]

bump version 2.12.0a0 -> 2.12.0a1

f0b5230

tcompa temporarily deployed to pypi February 3, 2025 11:26 — with GitHub Actions Inactive

Fix f-string

9eb5b6d

tcompa mentioned this pull request Feb 3, 2025

Add test for cancelling parallel task #2238

Closed

tcompa added 2 commits February 3, 2025 13:46

Revert "Fix f-string"

21fbb53

This reverts commit 9eb5b6d.

Revert "Improve `test_full_workflow_slurm_v2.py::test_failing_workflo…

1e30f2d

…w_JobExecutionError` [close #2238]" This reverts commit 5d8490c.

tcompa merged commit 02855cd into main Feb 3, 2025
19 checks passed

tcompa deleted the 2229-deprecate-v1-api-and-runner branch February 3, 2025 12:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate V1 (db tables, API, runner) #2230

Deprecate V1 (db tables, API, runner) #2230

tcompa commented Jan 29, 2025 •

edited

Loading

This comment was marked as off-topic.

github-actions bot commented Jan 29, 2025 •

edited

Loading

Deprecate V1 (db tables, API, runner) #2230

Deprecate V1 (db tables, API, runner) #2230

Conversation

tcompa commented Jan 29, 2025 • edited Loading

Checklist before merging

This comment was marked as off-topic.

github-actions bot commented Jan 29, 2025 • edited Loading

Coverage report

tcompa commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading