Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of db.refresh in aux functions #1548

Merged

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Jun 5, 2024

closes #1087

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Jun 5, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jun 5, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 1.1 1.0 1.10 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.9 0.89 0.0 0.0
job 0.8 1.0 0.80 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.6 11.3 0.67 0.7 0.7
power 373.6 424.0 0.88 440.2 440.2
dataset 149.2 172.5 0.86 171.2 171.2
project 44.5 54.5 0.82 58.9 58.9
job 28.5 33.8 0.84 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.3 6.8 0.78 2.4 2.4
power 131.5 144.9 0.91 693.4 693.4
dataset 135.4 148.7 0.91 989.2 989.2
project 44.1 51.8 0.85 310.0 310.0
job 35.1 39.7 0.88 245.6 245.6

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.6 7.2 0.78 0.1 0.1
power 5.3 6.8 0.78 0.1 0.1
dataset 5.3 7.0 0.76 0.1 0.1
project 7.0 8.6 0.81 2.3 2.3
job 5.2 7.0 0.74 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.9 11.5 0.77 0.8 0.8
power 22.1 28.6 0.77 29.8 29.8
dataset 18.7 20.1 0.93 17.1 17.1
project 19.5 23.1 0.84 21.5 21.5
job 8.7 11.4 0.76 0.9 0.9

POST /api/v2/project/3/dataset/402/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 145.2 163.9 0.89 275.1 275.1

Copy link

github-actions bot commented Jun 5, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/routes/api/v2
  _aux_functions.py
  fractal_server/app/runner/executors/slurm
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@ychiucco ychiucco merged commit 19f413a into main Jun 5, 2024
18 checks passed
@ychiucco ychiucco deleted the 1087-review-use-of-dbrefresh-in-aux-functions-performance-wise branch June 5, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review use of db.refresh in aux functions (performance-wise)
2 participants