Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify env.py #2234

Closed
tcompa opened this issue Jan 31, 2025 · 0 comments · Fixed by #2239
Closed

Simplify env.py #2234

tcompa opened this issue Jan 31, 2025 · 0 comments · Fixed by #2239
Assignees
@mfranzon
Labels
db life cycle Migrations and co maintenance

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jan 31, 2025 •
edited
Loading

  1. We should deprecate run_migrations_offline
  2. We should avoid using async engine
@tcompa tcompa added db life cycle Migrations and co maintenance labels Jan 31, 2025
@tcompa tcompa changed the title Review and deprecate run_migrations_online Review and deprecate run_migrations_offline Jan 31, 2025
@tcompa tcompa changed the title Review and deprecate run_migrations_offline Simplify env.py Feb 3, 2025
@mfranzon mfranzon linked a pull request Feb 3, 2025 that will close this issue
remove run_migrations_offline, make run_migrations_online sync #2239
Merged
3 tasks
@mfranzon mfranzon mentioned this issue Feb 3, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfranzon mfranzon

Labels
db life cycle Migrations and co maintenance
Projects
Fractal Project Management
Status: Done
Milestone
No milestone
2 participants
@tcompa @mfranzon