MQTT plugin doesn't seem to remove values from the valueMap after sending

[caluml]

Hi @fr3ts0n

I just installed v2.6.13 today which fixed a problem reading from the OBD device - thanks!

I am trying to use the MQTT plugin, and it seems to be working, apart from the fact that it sends the same data over and over.

Looking at the code in MqttPlugin, I can't see anywhere that it removes the sent data from valueMap after publishing it. Am I correct? (I am viewing it on Github, rather than in an IDE, so might be missing something).

Also, I am thinking of adding an HttpPlugin, to submit data to a configurable POST endpoint - any thoughts/advice? My plan is to take the MqttPlugin and use that as the template.
I'm thinking of submitting as a JSON payload, but might just submit it as something simpler if JSON makes it too complicated in Android and leave deserialising and interpretting to the server side.

[caluml]

I've understood more now what was happening.

I had gone to the car, used the app, and then turned the car off and come into the house with the app still active.

This meant that there were no new OBD updates being received, so it kept sending the last values over and over.

Maybe it makes more sense to clear the valueMap inside the synchronized block just after sending all the data?

[fr3ts0n]

Indeed, the plugin runs as long as the APP does. So the plugin re-published the last seen data readings.

Since data retrieval (AndrOBD) and data publishing (plugin) run asynchronously, it would contradict any data updating rules to clear data after send update. Worst case you get published empty data values sporadically. (which is a hassle to diagnose).

I could imagine to send an empty value list towards any publishing plugin in a "NO data" condition of the vehicle communication.

Would that solve your problem?