Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primary-site: update to v0.0.50 #99

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

bryfox
Copy link
Contributor

@bryfox bryfox commented Oct 17, 2024

Changelog

  • Change: a device name specified in foxglove MCAP metadata will now create the device if it does not yet exist

Docs

Description

https://github.com/foxglove/data-platform/pull/1271
FG-8580

Copy link

linear bot commented Oct 17, 2024

Copy link
Contributor

@bennetthardwick bennetthardwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should I be doing any kind of testing when a new set of helm charts are released?

@bryfox
Copy link
Contributor Author

bryfox commented Oct 17, 2024

Should I be doing any kind of testing when a new set of helm charts are released?

No, in general we should be doing verification before the code itself gets merged to main. In this case it's https://github.com/foxglove/data-platform/pull/1271 (I updated the PR description here for clarity) and I had tested that with a self-managed setup.

@bryfox bryfox merged commit e2a0c01 into main Oct 17, 2024
1 check passed
@bryfox bryfox deleted the bryan/fg-8580-release-primary-site branch October 17, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants