Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream-server: point to stream-server container in registry #76

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

james-rms
Copy link
Contributor

Public-Facing Changes

Description

  • https://github.com/foxglove/data-platform/pull/1098 inadvertently changed the destination path of the stream server image from stream-service to stream-server. This is the only docker image where the image has a different name from the underlying binary. It's a small difference and was missed. However, this is causing the helm chart to fail to launch the stream server:
j@192-168-1-105 helm-charts % docker run us-central1-docker.pkg.dev/foxglove-images/images/stream-service:083ea7cd15e5ca942125c5a3efaf0caa6fbd5d3e   
Unable to find image 'us-central1-docker.pkg.dev/foxglove-images/images/stream-service:083ea7cd15e5ca942125c5a3efaf0caa6fbd5d3e' locally
docker: Error response from daemon: manifest for us-central1-docker.pkg.dev/foxglove-images/images/stream-service:083ea7cd15e5ca942125c5a3efaf0caa6fbd5d3e not found: manifest unknown: Failed to fetch "083ea7cd15e5ca942125c5a3efaf0caa6fbd5d3e".
See 'docker run --help'.

This PR changes the image path in the helm chart, which is the least-invasive change i believe will cause this to start working again.

@defunctzombie defunctzombie merged commit 766e76f into main Feb 23, 2024
2 checks passed
@defunctzombie defunctzombie deleted the jrms/stream-server-service branch February 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants