Add support for nodeSelector on deployments #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| metrics: | ||
| namespace: "" | ||
| subsystem: "" | ||
| env: [] | ||
| env: |
There was a problem hiding this comment.
What's this change about? Your code editor decided to move the []?
wimagguc
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Looks reasonable to me; will let @foxglovenes to take the helm and approve.
foxglovenes
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Adding support for nodeSelector(s) on deployments
Description
We are currently running two clusters, x86 and ARM64. We want to migrate to a single cluster (currently only ARM64) with an additional NodePool for x86 services, of which Foxglove is the primary. In order to target Foxglove to those nodes (and not the ARM64), we need to be able to set nodeSelectors on the deployments.