add proxy support to garbage collector #110
Conversation
There was a problem hiding this comment.
I'm going to leave this for team fire to review.
These might be supported in Go, but from some quick searching, it looks like the rust library obeys NO_PROXY (docs) and not the others (some old discussion here). So may require some eng support as we migrate? I don't have much context for this, though.
|
This behavior already exists in the rest of the services, it was missing from garbage collector though. I have noted this for future compatibility. |
There was a problem hiding this comment.
These might be supported in Go, but from some quick searching, it looks like the rust library obeys NO_PROXY (docs) and not the others (some old discussion here). So may require some eng support as we migrate? I don't have much context for this, though.
My understanding is that it was missing from #106 which is already tested/used? So probably good to go.
Changelog
Fix: Add HTTP proxy support to garbage collector
Docs
None
Description
Add HTTP proxying support to garbage collector cronjob.