Skip to content

Commit

Permalink
bump primary site to v0.0.41 (#83)
Browse files Browse the repository at this point in the history
### Changelog
#### Inbox listener
- Changed: if a file is provided with an invalid device name or ID, the
import will fail immediately rather than being retried repeatedly.
- Added: MCAP files containing channels with schema ID 0 (no schema)
will be successfully imported.
- Added: Inbox listener will sort messages in files by their log time
while importing. See
https://docs.foxglove.dev/docs/primary-sites/self-hosting/inbox-listener-configuration
for configuration options relating to this change.
#### Stream server
- Fixed: when a stream server pod is sent SIGTERM, it waits
for`SHUTDOWN_TIMEOUT` seconds for any open requests to complete.
Previously when this timeout was exceeded, the stream server would exit
uncleanly and log an error. After this change, the stream server logs a
warning and exits cleanly.
- Added: stream server will serve MCAP channels with schema ID 0 (no
schema) successfully.

### Docs

foxglove/docs#297

### Description

Updates revision to include features described in changelog. Also adds
configuration options to allow deployer to configure local disk for
their inbox listener to use.

### Testing
- [x] tested local disk configuration and use on my local sandbox
cluster, works as advertised
  • Loading branch information
james-rms authored Jun 7, 2024
1 parent c0e5cd3 commit 70ba2f6
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 2 deletions.
6 changes: 4 additions & 2 deletions charts/primary-site/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ type: application
# 1.0.0-alpha.0
# 1.0.0-alpha.1
# 1.0.0
version: "0.0.40"
version: "0.0.41"

appVersion: "610223e5f22ba95225f598df955e578e839f8d9a"


appVersion: "e913c8f049a5ed252b4b54b0cbae08459fc5dd85"
21 changes: 21 additions & 0 deletions charts/primary-site/templates/deployments/inbox-listener.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,34 @@ spec:
secret:
secretName: gcp-cloud-credential
optional: true
{{- if .Values.inboxListener.deployment.localScratch.enabled }}
- name: local-scratch
emptyDir:
sizeLimit: {{ .Values.inboxListener.deployment.localScratch.capacityBytes }}
{{- end }}
containers:
- name: inbox-listener
image: us-central1-docker.pkg.dev/foxglove-images/images/inbox-listener:{{ .Chart.AppVersion }}
resources:
requests:
cpu: {{ .Values.inboxListener.deployment.resources.requests.cpu }}
memory: {{ .Values.inboxListener.deployment.resources.requests.memory }}
{{- if .Values.inboxListener.deployment.localScratch.enabled }}
ephemeral-storage: {{ .Values.inboxListener.deployment.localScratch.capacityBytes }}
{{- end}}
limits:
cpu: {{ .Values.inboxListener.deployment.resources.limits.cpu }}
memory: {{ .Values.inboxListener.deployment.resources.limits.memory }}
{{- if .Values.inboxListener.deployment.localScratch.enabled }}
ephemeral-storage: {{ .Values.inboxListener.deployment.localScratch.capacityBytes }}
{{- end}}
volumeMounts:
- mountPath: /secrets
name: cloud-credentials
{{- if .Values.inboxListener.deployment.localScratch.enabled }}
- mountPath: /local-scratch
name: local-scratch
{{- end }}
ports:
- name: metrics
containerPort: 6001
Expand Down Expand Up @@ -102,6 +117,12 @@ spec:
- name: {{ $item.name }}
value: {{ $item.value | quote}}
{{- end }}
{{- if .Values.inboxListener.deployment.localScratch.enabled }}
- name: LOCAL_SCRATCH_ROOT
value: "/local-scratch"
- name: LOCAL_SCRATCH_CAPACITY_BYTES
value: "{{ .Values.inboxListener.deployment.localScratch.capacityBytes }}"
{{- end }}
{{- if .Values.inboxListener.deployment.serviceAccount.enabled }}
serviceAccount: inbox-listener
{{- end}}
Expand Down
12 changes: 12 additions & 0 deletions charts/primary-site/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,18 @@ inboxListener:
# inbox listener.
# - name: AWS_WRITER_PART_SIZE_BYTES
# value: 5242880
# SCRATCH_BUFFER_CAPACITY_BYTES: The maximum buffer size that will be used when reading
# indexed MCAP. During processing, some file data is read into memory before being written to
# the lake. If the message timestamps in a file are highly out-of-order, this limit may be
# exceeded. If the limit is exceeded, local disk or lake storage is used instead of memory.
# - name: SCRATCH_BUFFER_CAPACITY_BYTES
# value: "1073741824"
localScratch:
# If your primary site is expected to process unindexed MCAP or ROS 1 BAG files, consider
# configuring your inbox listener deployment with local scratch storage. We recommend
# allocating at least three times as much capacity as your largest expected input file size.
enabled: false
capacityBytes: "107374182400"

serviceAccount:
enabled: false
Expand Down

0 comments on commit 70ba2f6

Please sign in to comment.