Skip to content

Commit

Permalink
primary-site: plumb through chart version to app (#100)
Browse files Browse the repository at this point in the history
### Changelog
- Changed: the "legacy MCAP" stream output format has been removed.
Stream requests with no requested output format will return valid
[MCAP](https://mcap.dev) data.
- Changed: Primary site will display the helm chart version as "site
version" in the Foxglove app.
### Docs

None.

### Description


<table><tr><th>Before</th><th>After</th></tr><tr><td>

Site version is reported as the git hash of the data-platform repo used
by this helm chart ("appVersion" in Chart.yaml)

</td><td>

Site version is reported as the helm chart ("version" in Chart.yaml)

</td></tr></table>

Fixes:
  • Loading branch information
james-rms authored Nov 6, 2024
1 parent e2a0c01 commit 22ffdb6
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 2 deletions.
4 changes: 2 additions & 2 deletions charts/primary-site/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ type: application
# 1.0.0-alpha.0
# 1.0.0-alpha.1
# 1.0.0
version: "0.0.50"
version: "0.0.51"

appVersion: "c7d4a5ee584e2cbd837e54542c4afb776f2fdb96"
appVersion: "79aed2aaac91cb942467185b7c1f74454cb0fefe"
2 changes: 2 additions & 0 deletions charts/primary-site/templates/cronjobs/garbage-collector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ spec:
value: "{{ .Values.globals.aws.region }}"
- name: AWS_SDK_LOAD_CONFIG
value: "true"
- name: PRIMARY_SITE_VERSION
value: "{{ .Chart.Version }}"
{{- range $item := .Values.garbageCollector.deployment.env }}
- name: {{ $item.name }}
value: {{ $item.value | quote}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ template:
value: "{{ .Values.inboxListener.deployment.metrics.namespace }}"
- name: PROMETHEUS_METRICS_SUBSYSTEM
value: "{{ .Values.inboxListener.deployment.metrics.subsystem }}"
- name: PRIMARY_SITE_VERSION
value: "{{ .Chart.Version }}"
{{- range $item := .Values.inboxListener.deployment.env }}
- name: {{ $item.name }}
value: {{ $item.value | quote}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ spec:
value: {{ .Values.siteController.deployment.metrics.namespace }}
- name: PROMETHEUS_METRICS_SUBSYSTEM
value: {{ .Values.siteController.deployment.metrics.subsystem }}
- name: PRIMARY_SITE_VERSION
value: {{ .Chart.Version }}
{{- range $item := .Values.siteController.deployment.env }}
- name: {{ $item.name }}
value: {{ $item.value | quote}}
Expand Down
2 changes: 2 additions & 0 deletions charts/primary-site/templates/deployments/stream-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ spec:
value: "{{ .Values.streamService.deployment.metrics.namespace }}"
- name: PROMETHEUS_METRICS_SUBSYSTEM
value: "{{ .Values.streamService.deployment.metrics.subsystem }}"
- name: PRIMARY_SITE_VERSION
value: "{{ .Chart.Version }}"
{{- range $item := .Values.streamService.deployment.env }}
- name: {{ $item.name }}
value: {{ $item.value | quote}}
Expand Down

0 comments on commit 22ffdb6

Please sign in to comment.