Fail when mdbook build has errors #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
changed the title
franciszekjob
changed the title
franciszekjob
requested review from
cptartur,
ddoktorski and
kkawula
as code owners
cptartur
approved these changes
Dec 16, 2024
… into franciszekjob/2756-fix
…s/starknet-foundry into franciszekjob/2756-fix
kkawula
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2756
Introduced changes
Add a script which exits with code 1 in case when there are errors when running
mdbook build. This should be ofc done on mdbook's project side, however it hasn't been addressed yet (rust-lang/mdBook#2277).Example run with broken docs url:
https://github.com/foundry-rs/starknet-foundry/actions/runs/12329947653/job/34414855443
Checklist
CHANGELOG.md