Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tweak coverage warnings #9814

Merged
merged 1 commit into from
Feb 2, 2025
Merged

chore: tweak coverage warnings #9814

merged 1 commit into from
Feb 2, 2025

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Feb 2, 2025 •
edited
Loading

  • Tweak wording
  • mention that viaIR gets disabled as well
  • move second warning inside the else branch so as to not emit 2 warnings with a similar message on --ir-minimum

grandizzy
grandizzy approved these changes Feb 2, 2025
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grandizzy grandizzy added the L-ignore Log: ignore PR in changelog label Feb 2, 2025
@DaniPopes DaniPopes enabled auto-merge (squash) February 2, 2025 20:48
@DaniPopes DaniPopes merged commit 0e519ff into master Feb 2, 2025
22 checks passed
@DaniPopes DaniPopes deleted the dani/coverage-via-ir branch February 2, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grandizzy grandizzy grandizzy approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
L-ignore Log: ignore PR in changelog
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @grandizzy