-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anvil): implement anvil_rollback
#9783
Conversation
anvil_rollback
anvil_rollback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, overall looks good! left couple of comments, please check
thank you, looks good, clippy failures not related, going to fix them in master and rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! lgtm
Motivation
Adds
anvil_rollback
RPC method. This method allows users to undo blocks that already been produced.The existing
anvil_reorg
doesn't allow you to actually remove blocks, only to re-org in place.Solution
The code is similar to
anvil_reorg
, we simply skip the mining step.