Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfulfilled learning outcome #25

Open
eliasmalik opened this issue Jan 19, 2018 · 2 comments
Open

Unfulfilled learning outcome #25

eliasmalik opened this issue Jan 19, 2018 · 2 comments
Assignees

Comments

@eliasmalik
Copy link
Member

In the README:

Running queries in Node

...

  • Using parameterised queries (to prevent SQL injection)

I've looked through the walkthrough steps and there doesn't seem to be anywhere where this learning outcome is fulfilled. Step 3 Part 7 is the only place where the parameterised version of the Client.query command is written, but it's just an aside to the mentor.

I'd suggest either adding an INSERT query at the end of the code-along, or substituting the existing SELECT query for one.

@VirtualDOMinic
Copy link

Have requested the reviewers of the relevant pull request to merge and close

@mattlub
Copy link
Contributor

mattlub commented Nov 27, 2018

@eliasCodes there is an old PR (#26 ) open to add an insert query, but maybe it would be better to just remove the learning outcome for now?

INSERT is covered in the workshop which follows this one: https://github.com/foundersandcoders/pg-workshop

@mattlub mattlub assigned eliasmalik and unassigned sultanassi95 Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants