Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update queryappend.json #1652

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Update queryappend.json #1652

merged 2 commits into from
Apr 29, 2024

Conversation

scallahan-dev
Copy link
Contributor

Added support for Lucee 6.0.0.15

Added support for Lucee 6.0.0.15
Fixed Lucee version number since it doesn't allow for micro versioning
@scallahan-dev
Copy link
Contributor Author

@pfreitag You may want to update the Lucee version regex in the JSON validator to allow for micro versioning. This didn't pass JSON validation when I entered 6.0.0.15, but that is the official version this function was added to Lucee.

@pfreitag
Copy link
Member

yeah, I think we were hoping to support semver style versions there. Could you add in the notes of the engine key the exact version?

@pfreitag pfreitag merged commit 9070a61 into foundeo:master Apr 29, 2024
4 checks passed
@pfreitag
Copy link
Member

going to merge this since the number of people running a version of 6.0.0 less than 6.0.0.15 has to be close to zero, but feel free to add the note in another PR

@scallahan-dev
Copy link
Contributor Author

going to merge this since the number of people running a version of 6.0.0 less than 6.0.0.15 has to be close to zero, but feel free to add the note in another PR

Unless Brad is still messing around with testing something 😝

@scallahan-dev scallahan-dev deleted the patch-3 branch May 29, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants