Make copying nested styles more concise #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pante
had a problem deploying
to
docs-development
GitHub Actions
Failure
There was a problem hiding this comment.
Copilot reviewed 73 out of 88 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- docs/pages/docs/themes.mdx: Language not supported
- forui/.gitignore: Language not supported
- forui/lib/foundation.dart: Language not supported
- forui/lib/src/foundation/focused_outline.dart: Language not supported
- forui/lib/src/foundation/transform.dart: Language not supported
- forui/lib/src/localizations/localizations.dart: Language not supported
- forui/lib/src/theme/color_scheme.dart: Language not supported
- forui/lib/src/theme/form_field_style.dart: Language not supported
- forui/lib/src/theme/style.dart: Language not supported
- forui/lib/src/theme/theme_data.dart: Language not supported
- forui/lib/src/theme/themes.dart: Language not supported
- forui/lib/src/theme/typography.dart: Language not supported
- forui/lib/src/widgets/accordion/accordion.dart: Language not supported
- forui/lib/src/widgets/alert.dart: Language not supported
- forui/lib/src/widgets/avatar/avatar.dart: Language not supported
…experiment/concise-styles
Pante
had a problem deploying
to
docs-development
GitHub Actions
Failure
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Pante
had a problem deploying
to
docs-development
GitHub Actions
Failure
…experiment/concise-styles
Pante
had a problem deploying
to
docs-development
GitHub Actions
Failure
kawaijoe
approved these changes
Feb 9, 2025
Daviiddoo
approved these changes
Feb 9, 2025
najm101
pushed a commit
to najm101/forui
that referenced
this pull request
Feb 10, 2025
* Refactor FThemeData * Add forui_internal_gen * Refactor styles to use forui_internal_gen * Update documentation * Remove redundant transform * refactor styles * Commit from GitHub Actions (Forui Presubmit) * Fix failing build * Commit from GitHub Actions (Forui Internal Gen Presubmit) * Update CONTRIBUTING.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix failing build --------- Co-authored-by: Pante <Pante@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
najm101
pushed a commit
to najm101/forui
that referenced
this pull request
Feb 10, 2025
* Refactor FThemeData * Add forui_internal_gen * Refactor styles to use forui_internal_gen * Update documentation * Remove redundant transform * refactor styles * Commit from GitHub Actions (Forui Presubmit) * Fix failing build * Commit from GitHub Actions (Forui Internal Gen Presubmit) * Update CONTRIBUTING.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix failing build --------- Co-authored-by: Pante <Pante@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Fixes #360
We ended up implementing our own code gen tool. Deeply nested copies can be created via
transformfunctions.Checklist