fix: catch RecursionError in initialization #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnikit
force-pushed
the
fix/recursion-error-in-initialization
branch
from
3c17071 to
87dc8f4
Compare
|
I'll have a look at this a bit later today (hopefully). I'll play with it a bit and see if there is a nice way of reporting this error + testing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 88.26% 88.33% +0.06%
==========================================
Files 35 35
Lines 4797 4800 +3
==========================================
+ Hits 4234 4240 +6
+ Misses 563 560 -3 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Mar 1, 2025
gnikit
force-pushed
the
fix/recursion-error-in-initialization
branch
from
87dc8f4 to
def63f4
Compare
multiprocessing.Pool does not retain the base exception that caused it to raise. As a result it is not possible under this setup to explicitly capture the RecursionError that is getting raised when Pool attempts to pickle the AST from the parser.
…tion handling mechanism
gnikit
force-pushed
the
fix/recursion-error-in-initialization
branch
from
91ce467 to
f00b8ea
Compare
gnikit
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the suggested fix for #445. Please see #445 for the exact description about what this fix is trying to address.
The issue can be addressed by catching the errors raised from
result.get()(receivning the result from the child process) inLangServer.workspace_init. The caught error can be convereted to string so that it will be posted as an error message.With this fix, the fortls reports an "Initialization failed" message for the file that caused the RecusrionError, and successfully completes the initialization instead of crashing itself. It looks like below in VSCode (The red underline indicates the file that caused the issue).