Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize R2 flush part implementation #16

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Optimize R2 flush part implementation #16

merged 2 commits into from
Jan 11, 2024

Conversation

aomerk
Copy link
Contributor

@aomerk aomerk commented Jan 10, 2024 •
edited
Loading

Changes:

  • Fills up the ready part if it's smaller than chunk size
  • If part is the final part, flushes even if it's smaller than chunk size

compliant with R2 restrictions

canercidam
canercidam reviewed Jan 10, 2024
View reviewed changes
drivers/r2/driver.go Outdated Show resolved Hide resolved
@aomerk @canercidam
Update drivers/r2/driver.go
6bd514f 
Co-authored-by: Caner Çıdam <canercidam01@gmail.com>
@aomerk aomerk merged commit c2d10dd into master Jan 11, 2024
1 check passed
@aomerk aomerk deleted the ali/optimize-flushes branch January 11, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canercidam canercidam canercidam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aomerk @canercidam