Extract json patch to mongo update logic to a separate method.

formapro · Mar 13, 2017 · c975a77 · c975a77
1 parent 1093a85
commit c975a77
Show file tree

Hide file tree

Showing 2 changed files with 63 additions and 48 deletions.
diff --git a/src/ChangesCollector.php b/src/ChangesCollector.php
@@ -34,53 +34,6 @@ public function changes($object)
 
         $diff = JsonPatch::diff($this->originalValues[$id], get_values($object));
 
-        $update = ['$set' => [], '$unset' => []];
-        foreach ($diff as $op) {
-            switch ($op['op']) {
-                case 'add':
-                    if (is_array($op['value'])) {
-                        foreach ($op['value'] as $key => $value) {
-                            $update['$set'][$this->pathToDot($op['path']).'.'.$key] = $value;
-                        }
-                    } else {
-                        $update['$set'][$this->pathToDot($op['path'])] = $op['value'];
-                    }
-
-                    break;
-                case 'remove':
-                    $update['$unset'][$this->pathToDot($op['path'])] = '';
-
-                    break;
-                case 'replace':
-                    $update['$set'][$this->pathToDot($op['path'])] = $op['value'];
-
-                    break;
-                default:
-                    throw new \LogicException('JSON Patch operation "'.$op['op'].'"" is not supported.');
-            }
-
-
-        }
-
-        if (empty($update['$set'])) {
-            unset($update['$set']);
-        }
-        if (empty($update['$unset'])) {
-            unset($update['$unset']);
-        }
-
-        return $update;
-    }
-
-    /**
-     * @param string $path
-     *
-     * @return string
-     */
-    private function pathToDot($path)
-    {
-        $path = ltrim($path, '/');
-
-        return str_replace('/', '.', $path);
+        return Converter::convertJsonPatchToMongoUpdate($diff);
     }
 }
diff --git a/src/Converter.php b/src/Converter.php
@@ -0,0 +1,62 @@
+<?php
+namespace Makasim\Yadm;
+
+class Converter
+{
+    /**
+     * @param array $diff
+     * 
+     * @return array
+     */
+    public static function convertJsonPatchToMongoUpdate(array $diff)
+    {
+        $update = ['$set' => [], '$unset' => []];
+        foreach ($diff as $op) {
+            switch ($op['op']) {
+                case 'add':
+                    if (is_array($op['value'])) {
+                        foreach ($op['value'] as $key => $value) {
+                            $update['$set'][self::pathToDot($op['path']).'.'.$key] = $value;
+                        }
+                    } else {
+                        $update['$set'][self::pathToDot($op['path'])] = $op['value'];
+                    }
+
+                    break;
+                case 'remove':
+                    $update['$unset'][self::pathToDot($op['path'])] = '';
+
+                    break;
+                case 'replace':
+                    $update['$set'][self::pathToDot($op['path'])] = $op['value'];
+
+                    break;
+                default:
+                    throw new \LogicException('JSON Patch operation "'.$op['op'].'"" is not supported.');
+            }
+
+
+        }
+
+        if (empty($update['$set'])) {
+            unset($update['$set']);
+        }
+        if (empty($update['$unset'])) {
+            unset($update['$unset']);
+        }
+
+        return $update;
+    }
+
+    /**
+     * @param string $path
+     *
+     * @return string
+     */
+    private static function pathToDot($path)
+    {
+        $path = ltrim($path, '/');
+
+        return str_replace('/', '.', $path);
+    }
+}