fix: connection leaks #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio-form3
commented
Feb 7, 2025
alessio-form3
commented
- run sql.Open only during collector initialisation.
- make the number of max and max idle connections configurable and give them sensible defaults.
- add a timeout to each collector scrape.
- better shut down handling
alessio-form3
commented
Feb 7, 2025
| return nil, err | ||
| } | ||
|
|
||
| err = instance.setup() |
There was a problem hiding this comment.
Calling setup on the instance at the collector instantiation.
alessio-form3
force-pushed
the
ap-fix-connection-leaks
branch
from
07eed02 to
4cb728c
Compare
kukulam-form3
approved these changes
Feb 7, 2025
mario-form3
reviewed
Feb 7, 2025
mario-form3
reviewed
Feb 7, 2025
- run sql.Open only during collector initialisation. - make the number of max and max idle connections configurable and give them sensible defaults. - add a timeout to each collector scrape. - better shut down handling - removed probe
alessio-form3
force-pushed
the
ap-fix-connection-leaks
branch
from
4cb728c to
27ceefc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.