40698660: Make asJquery() work within a shadow DOM #529
Conversation
DamienCassou
force-pushed
the
40698660/Make_asJquery_work_within_a_shadow_DOM
branch
2 times, most recently
from
a515cdb to
1de4ef0
Compare
DamienCassou
requested review from
danglotb,
josquindebaz,
benemotz,
ValentinaVasile and
JohanBriglia
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 1 of 1 files at r2, 4 of 4 files at r3, 1 of 1 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @benemotz, @BenjaminVanRyseghem, @DamienCassou, @danglotb, @JohanBriglia, and @ValentinaVasile)
src/test/widgetTest.js line 258 at r5 (raw file):
it("returns true if the widget is attached to the DOM under a special shadow host", () => { expect.assertions(1);
NIT: It's not crystal clear why this have to be used. May be a comment like "making sure promise is called" could help?
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 1 of 1 files at r2, 4 of 4 files at r3, 1 of 1 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @benemotz, @BenjaminVanRyseghem, @danglotb, @josquindebaz, and @ValentinaVasile)
src/test/widgetTest.js line 258 at r5 (raw file):
Previously, josquindebaz (Josquin Debaz) wrote…
NIT: It's not crystal clear why this have to be used. May be a comment like "making sure promise is called" could help?
+1
…ow trees In the previous version, widget.asJQuery() would only return something useful if the widget is directly attached to the document. If the widget is within a shadow tree, asJQuery() wouldn't work. This commit makes asJQuery() work even if widget is within a shadow tree if and only if: - this tree is attached to a host node with widgetjs-shadow=document, - and there is only one such node in the DOM This limitation on the host avoids impacting too much the performance.
DamienCassou
force-pushed
the
40698660/Make_asJquery_work_within_a_shadow_DOM
branch
from
1de4ef0 to
5a2ad83
Compare
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @benemotz, @BenjaminVanRyseghem, @danglotb, and @ValentinaVasile)
src/test/widgetTest.js line 258 at r5 (raw file):
Previously, JohanBriglia wrote…
+1
done
DamienCassou
deleted the
40698660/Make_asJquery_work_within_a_shadow_DOM
branch
This change is