-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STCOM-1343 refactor away from findDOMNode
#2352
Conversation
Bigtest Unit Test Results 1 files ±0 1 suites ±0 14s ⏱️ ±0s Results for commit 3a2aa86. ± Comparison against base commit 23a0c49. This pull request removes 1515 and adds 1515 tests. Note that renamed tests count towards both.
This pull request removes 8 skipped tests and adds 8 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please also update CHANGELOG
Quality Gate passedIssues Measures |
* provide refs where able * remove wrapping elements from RowMeasurer and CellMeasurer * metasection header * fix useImperativeHandle in meta-accordion * resolve MCL tests, point at srh branch with fix... * have accordion supply its own container for header/hotkey catching. * switch from branch of stripes-react-hotkeys * update yarn.lock to use updated stripes-react-hotkeys * consistently use renderprops for CellMeasurer * Update CHANGELOG.md
This touches Accordion (including MetaSection), MCL, and AdvancedSearch so far...
This goes in-hand with folio-org/stripes-react-hotkeys#44 (Merged!)
Summary of changes:
findDOMNode