Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOM-1343 refactor away from findDOMNode #2352

Merged
merged 11 commits into from
Sep 30, 2024
Merged

STCOM-1343 refactor away from findDOMNode #2352

merged 11 commits into from
Sep 30, 2024

Conversation

JohnC-80
Copy link
Contributor

@JohnC-80 JohnC-80 commented Sep 20, 2024

This touches Accordion (including MetaSection), MCL, and AdvancedSearch so far...
This goes in-hand with folio-org/stripes-react-hotkeys#44 (Merged!)

Summary of changes:

  • In general, Instances of Hotkeys are provided with a ref to a wrapping element.
  • AdvancedSearch Modal: wrapping div added.
  • MCL components for dom-measuring refactor to contain their rendered elements/implement as a child function providing the necessary ref as opposed to using findDOMNode
  • Accordion headers wrapped in a div with a ref to that div provided to HotKeys.

Copy link

github-actions bot commented Sep 20, 2024

Bigtest Unit Test Results

    1 files  ±0      1 suites  ±0   14s ⏱️ ±0s
1 515 tests ±0  1 507 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 517 runs  ±0  1 509 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 3a2aa86. ± Comparison against base commit 23a0c49.

This pull request removes 1515 and adds 1515 tests. Note that renamed tests count towards both.
Chrome_128_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet contents ready for interaction following open ‑ Accordion - as part of an AccordionSet contents ready for interaction following open Child element was filled out successfully
Chrome_128_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet keyboard navigation: first accordion ‑ Accordion - as part of an AccordionSet keyboard navigation: first accordion First accordion is in focus
Chrome_128_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet keyboard navigation: last accordion ‑ Accordion - as part of an AccordionSet keyboard navigation: last accordion Last accordion is in focus
Chrome_128_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet keyboard navigation: next accordion ‑ Accordion - as part of an AccordionSet keyboard navigation: next accordion second accordion is in focus
Chrome_128_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet keyboard navigation: previous accordion ‑ Accordion - as part of an AccordionSet keyboard navigation: previous accordion first accordion is in focus
Chrome_128_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet ‑ Accordion - as part of an AccordionSet has a button
Chrome_128_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet ‑ Accordion - as part of an AccordionSet has no axe errors
Chrome_128_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet ‑ Accordion - as part of an AccordionSet should call onRegisterAccordion callback
Chrome_128_0_0_0_(Linux_x86_64).Accordion - updating state of parent component opening the closed accordion changing the text value/parent state ‑ Accordion - updating state of parent component opening the closed accordion changing the text value/parent state renders second accordion as open
Chrome_128_0_0_0_(Linux_x86_64).Accordion - updating state of parent component opening the closed accordion changing the text value/parent state ‑ Accordion - updating state of parent component opening the closed accordion changing the text value/parent state renders state value in textField
…
Chrome_129_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet contents ready for interaction following open ‑ Accordion - as part of an AccordionSet contents ready for interaction following open Child element was filled out successfully
Chrome_129_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet keyboard navigation: first accordion ‑ Accordion - as part of an AccordionSet keyboard navigation: first accordion First accordion is in focus
Chrome_129_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet keyboard navigation: last accordion ‑ Accordion - as part of an AccordionSet keyboard navigation: last accordion Last accordion is in focus
Chrome_129_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet keyboard navigation: next accordion ‑ Accordion - as part of an AccordionSet keyboard navigation: next accordion second accordion is in focus
Chrome_129_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet keyboard navigation: previous accordion ‑ Accordion - as part of an AccordionSet keyboard navigation: previous accordion first accordion is in focus
Chrome_129_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet ‑ Accordion - as part of an AccordionSet has a button
Chrome_129_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet ‑ Accordion - as part of an AccordionSet has no axe errors
Chrome_129_0_0_0_(Linux_x86_64).Accordion - as part of an AccordionSet ‑ Accordion - as part of an AccordionSet should call onRegisterAccordion callback
Chrome_129_0_0_0_(Linux_x86_64).Accordion - updating state of parent component opening the closed accordion changing the text value/parent state ‑ Accordion - updating state of parent component opening the closed accordion changing the text value/parent state renders second accordion as open
Chrome_129_0_0_0_(Linux_x86_64).Accordion - updating state of parent component opening the closed accordion changing the text value/parent state ‑ Accordion - updating state of parent component opening the closed accordion changing the text value/parent state renders state value in textField
…
This pull request removes 8 skipped tests and adds 8 skipped tests. Note that renamed tests count towards both.
Chrome_128_0_0_0_(Linux_x86_64).Datepicker defaultOutputFormatter converts non-Latn input to Latn-output ‑ Datepicker defaultOutputFormatter converts non-Latn input to Latn-output returns a Latn (Arabic, 0-9) string
Chrome_128_0_0_0_(Linux_x86_64).Datepicker with Redux Form integration exclude prop selecting excluded date navigation on excluded date ‑ Datepicker with Redux Form integration exclude prop selecting excluded date navigation on excluded date changed cursor to April 2, 2018
Chrome_128_0_0_0_(Linux_x86_64).Editor rendering a basic Editor ‑ Editor rendering a basic Editor has no axe errors. - Editor
Chrome_128_0_0_0_(Linux_x86_64).Popover If the legacy component API is used When the toggle is clicked again ‑ Popover If the legacy component API is used When the toggle is clicked again Hides the popover overlay
Chrome_128_0_0_0_(Linux_x86_64).Popover If the legacy component API is used ‑ Popover If the legacy component API is used Renders the legacy popover and opens the overlay when the toggle is clicked
Chrome_128_0_0_0_(Linux_x86_64).childrenOf propType validator Passing a type that isn't allowed ‑ childrenOf propType validator Passing a type that isn't allowed triggers a propType error
Chrome_128_0_0_0_(Linux_x86_64).childrenOf propType validator Passing a type that isn't allowed ‑ childrenOf propType validator Passing a type that isn't allowed triggers no proptype error
Chrome_128_0_0_0_(Linux_x86_64).childrenOf propType validator not providing a required prop ‑ childrenOf propType validator not providing a required prop triggers a required propType error
Chrome_129_0_0_0_(Linux_x86_64).Datepicker defaultOutputFormatter converts non-Latn input to Latn-output ‑ Datepicker defaultOutputFormatter converts non-Latn input to Latn-output returns a Latn (Arabic, 0-9) string
Chrome_129_0_0_0_(Linux_x86_64).Datepicker with Redux Form integration exclude prop selecting excluded date navigation on excluded date ‑ Datepicker with Redux Form integration exclude prop selecting excluded date navigation on excluded date changed cursor to April 2, 2018
Chrome_129_0_0_0_(Linux_x86_64).Editor rendering a basic Editor ‑ Editor rendering a basic Editor has no axe errors. - Editor
Chrome_129_0_0_0_(Linux_x86_64).Popover If the legacy component API is used When the toggle is clicked again ‑ Popover If the legacy component API is used When the toggle is clicked again Hides the popover overlay
Chrome_129_0_0_0_(Linux_x86_64).Popover If the legacy component API is used ‑ Popover If the legacy component API is used Renders the legacy popover and opens the overlay when the toggle is clicked
Chrome_129_0_0_0_(Linux_x86_64).childrenOf propType validator Passing a type that isn't allowed ‑ childrenOf propType validator Passing a type that isn't allowed triggers a propType error
Chrome_129_0_0_0_(Linux_x86_64).childrenOf propType validator Passing a type that isn't allowed ‑ childrenOf propType validator Passing a type that isn't allowed triggers no proptype error
Chrome_129_0_0_0_(Linux_x86_64).childrenOf propType validator not providing a required prop ‑ childrenOf propType validator not providing a required prop triggers a required propType error

♻️ This comment has been updated with latest results.

@JohnC-80 JohnC-80 marked this pull request as ready for review September 25, 2024 15:24
@JohnC-80 JohnC-80 requested review from zburke, BogdanDenis and a team September 25, 2024 15:27
Copy link
Contributor

@BogdanDenis BogdanDenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please also update CHANGELOG

Copy link

sonarcloud bot commented Sep 26, 2024

@JohnC-80 JohnC-80 merged commit 5792577 into master Sep 30, 2024
25 checks passed
@JohnC-80 JohnC-80 deleted the STCOM-1343 branch September 30, 2024 13:47
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
* provide refs where able

* remove wrapping elements from RowMeasurer and CellMeasurer

* metasection header

* fix useImperativeHandle in meta-accordion

* resolve MCL tests, point at srh branch with fix...

* have accordion supply its own container for header/hotkey catching.

* switch from branch of stripes-react-hotkeys

* update yarn.lock to use updated stripes-react-hotkeys

* consistently use renderprops for CellMeasurer

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants