-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MODSOURCE-840] Extend domain event with source MARC #664
Merged
Merged
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bdcb137
[MODSOURCE-840] Extend domain event with source MARC
RomanChernetskyi ae2e419
Add tests for RecordDomainEventPublisher
RomanChernetskyi 1cb5237
Use deleteRecordBy id for soft delete of authority
RomanChernetskyi 90e076c
Merge branch 'master' into MODSOURCE-840
RomanChernetskyi 35bfc13
Add tests
RomanChernetskyi eee4265
Merge remote-tracking branch 'origin/MODSOURCE-840' into MODSOURCE-840
RomanChernetskyi 8f1262d
Fix sonar issues
RomanChernetskyi e174b54
Fix delete tests
RomanChernetskyi 1f7b843
Revert "Use deleteRecordBy id for soft delete of authority"
RomanChernetskyi 847a949
Remove unused import
RomanChernetskyi 8bb91b0
fix AuthorityDomainKafkaHandlerTest
RomanChernetskyi 028f7e7
Not send domain event on updateSuppressFromDiscoveryForRecord
RomanChernetskyi d309697
Send domain event without rawRecord and errorRecord
RomanChernetskyi f7b58e6
Remove unused imports from RecordDaoImpl
RomanChernetskyi f798b51
Not send raw record and error record on updateParsedRecord
RomanChernetskyi 1142a55
Fix typo
RomanChernetskyi 941b89d
Merge branch 'master' into MODSOURCE-840
RomanChernetskyi 52878db
Refine
RomanChernetskyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
288 changes: 164 additions & 124 deletions
288
mod-source-record-storage-server/src/main/java/org/folio/dao/RecordDaoImpl.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...rage-server/src/main/java/org/folio/services/domainevent/SourceRecordDomainEventType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
package org.folio.services.domainevent; | ||
|
||
public enum SourceRecordDomainEventType { | ||
SOURCE_RECORD_CREATED, SOURCE_RECORD_UPDATED | ||
SOURCE_RECORD_CREATED, SOURCE_RECORD_UPDATED, SOURCE_RECORD_DELETED | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be a delete event on soft delete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, we decided to send an update on the soft delete of Marc's records, but during further refinements, requirements could be changes