-
Notifications
You must be signed in to change notification settings - Fork 9
Add support upload collections #54
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 17.79% 21.02% +3.23%
==========================================
Files 3 3
Lines 399 428 +29
==========================================
+ Hits 71 90 +19
- Misses 315 320 +5
- Partials 13 18 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 but a bit confused... why do we need to do this? I thought for map tasks propeller is the one that assembles the list. and the individual tasks still upload single scalar items.
propeller expects output is a list with only one item. https://github.com/flyteorg/flyteplugins/blob/f577f62727a16a282edfa7a49d985e47a4ccef79/go/tasks/plugins/array/outputs.go#L121 |
because flytekit will convert output to a list literal. https://github.com/flyteorg/flytekit/blob/93995e29dcd37317e91ebcfb3019a4ffed0e82de/flytekit/core/map_task.py#LL56C47-L56C47 |
TL;DR
Add support upload collection (a list).
When using raw container in the map task, flytepropeller expect the subtask upload a list.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
https://flyte-org.slack.com/archives/CP2HDHKE1/p1678230956906899
Follow-up issue
NA