Vmu screen optimizations #1858

nexus382 · 2025-02-24T22:21:51Z

Added the ability to only render 1st VMU screen, added setting in GFX settings page.
Added the ability to change vmu screen sizes.
added ability to change transparency of VMU screens.
Settings both added in the Controls Page.

Also have DX11 renderer currently able to drage and move around the VMU screen. ( will do the other 3 after)

flyinghead · 2025-02-25T06:35:20Z

Rebase this PR on the current dev branch. Dreamconn commits from Tails86 are unrelated and there are merge conflicts.

nexus382 · 2025-02-25T23:35:25Z

I was afraid our work was going to mbe in there. First time using Git to this extent. cleaning now

…on screen, and move VMU window in DX 11 renderer

nexus382 · 2025-02-26T04:18:24Z

ok all done and cleaned up

(Thanks Tails)

flyinghead

Please test that the libretro core compiles and works properly with these changes.

flyinghead · 2025-02-26T06:42:45Z

core/rend/dx11/dx11_overlay.cpp

 		deviceContext->OMSetBlendState(blendStates.getState(true, 8, 8), blend_factor, 0xffffffff);
+		// Get current mouse position


This is only implemented for DX11 so it shouldn't be part of this PR. Also input polling should not be done in renderers.

ok thank you. I think i have this file put back. sorry, i had many bits, i thought i got them all, sorry.

flyinghead · 2025-02-26T06:44:25Z

core/rend/dx11/dx11_overlay.cpp

 		}
 	}
 	if (crosshair)
 	{
-		for (u32 i = 0; i < config::CrosshairColor.size(); i++)
+		for (size_t i = 0; i < vmuTextures.size(); i++)


Lightgun crosshairs and VMU displays are different things. This code shouldn't change.

ok, i am sorry, I p-ut it back

flyinghead · 2025-02-26T06:45:35Z

core/rend/dx11/dx11_overlay.cpp

-			x /= config::ScreenStretching / 100.f;
+				float halfWidth = lightgun_crosshair_size / 2.f / config::ScreenStretching * 100.f * config::RenderResolution / 480.f;
+				float halfHeight = lightgun_crosshair_size / 2.f * config::RenderResolution / 480.f;
+				x /= config::ScreenStretching / 100.f;


Avoid unnecessary white space changes as it makes it difficult to see the actual changes.

understood, i will copy and move a bloc to another sheet, so when i revert i copy and paste back. or paste a few line s to undo my changes. so I am sorry, I am still learning, Ill watch spacing better.

core/rend/dx11/dx11_overlay.h

flyinghead · 2025-02-26T06:47:10Z

core/rend/dx9/d3d_overlay.cpp

-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation, either version 2 of the License, or
-    (at your option) any later version.
+	Flycast is free software: you can redistribute it and/or modify


Unnecessary white space changes.

ok i think i did it
(after i commit the changes here in the PR, i dont think it is updating this view here, so i can not verify I made the proper changes. how can i refresh these to see if i fixed thoes issues?)

This view shows all commits but you haven't fixed this part.

white space changes still there

flyinghead · 2025-02-26T06:51:27Z

core/rend/gles/gldraw.cpp

 			drawGunCrosshair(i, width, height);
+			if (config::OnlyShowVMUA1)


Mixing up VMUs and crosshairs.

flyinghead · 2025-02-26T06:53:32Z

core/rend/vulkan/overlay.cpp

@@ -129,8 +129,8 @@ void VulkanOverlay::Draw(vk::CommandBuffer commandBuffer, vk::Extent2D viewport,
 	{
 #ifndef LIBRETRO
 		f32 vmu_padding = 8.f * scaling;
-		f32 vmu_height = 32.f * scaling;
-		f32 vmu_width = 48.f * scaling;
+		f32 vmu_height = 70.f * scaling * config::VmuScreenSize;


Why changing the default VMU height from 32 to 70?

This was because every VMU was handling the size change differently (they were all different sizes when going through the renderers), but this was done to help ensure all sizes and transparencies were the same across all the renderers with the sizing and transparency features. It's not like this VMU is larger when set to normal size (1x), but if you REALLY insist, I can change it back. I just fear it will break the uniformity again. From what I see, nothing has really changed from the inital sizing, but like I said, I can do it if we need to.

I don't see how more that doubling the VMU size can result in no visible size change at all.

flyinghead · 2025-02-26T06:54:10Z

core/rend/vulkan/overlay.cpp

@@ -245,6 +244,8 @@ void VulkanOverlay::Draw(vk::CommandBuffer commandBuffer, vk::Extent2D viewport,
 			};
 			xhairDrawer->Draw(commandBuffer, !imageViewBound ? xhairTexture->GetImageView() : vk::ImageView(), vtx, true, xhairColor);
 			imageViewBound = true;
+			if (config::OnlyShowVMUA1)
+				break;


not for crosshairs

flyinghead · 2025-02-26T06:54:26Z

core/types.h

@@ -162,6 +162,7 @@ struct settings_t
 		float refreshRate = 0;
 		float dpi = 96.f;
 		float uiScale = 1.f;
+


unnecessary white space change

flyinghead · 2025-02-26T06:54:49Z

core/ui/gui.cpp

@@ -2294,78 +2303,113 @@ static void gui_settings_video()
        	resLabels[i] += " (" + scalingsText[i] + ")";
        }

-        ImGui::PushItemWidth(ImGui::CalcItemWidth() - innerSpacing * 2.0f - ImGui::GetFrameHeight() * 2.0f);


Unnecessary white space changes

ok, I think I got these. I wish there was a way to SEE the changes im submitting in this view, to ensure with out you having to check and resubmit the issues.

will be much more careful in future about this. i found out when i copy and paste a block , i had it set to tbs, where flycast is mixed tab/space, so things goofed up. I have resolved this .

ok reverted code back.

rmoved extra blocks out of the file. I think i fixed ym spacing issues.i obviously messed up when copying the original blocks back over when diagonosing issues, and then paste my corrected blocks... so i willtry to be mroe careful with the spacing issues.

spacing and bit fixes

removed crosshair imposter

removed final break in crosshairs section

removed whitepspcae change

nexus382

ok Im still getting the hang of this, seems i did the long way round here. but lets see.

nexus382 · 2025-02-27T07:08:40Z

core/rend/dx11/dx11_overlay.cpp

 		deviceContext->OMSetBlendState(blendStates.getState(true, 8, 8), blend_factor, 0xffffffff);
+		// Get current mouse position


ok thank you. I think i have this file put back. sorry, i had many bits, i thought i got them all, sorry.

nexus382 · 2025-02-27T07:09:35Z

core/rend/dx11/dx11_overlay.cpp

 		}
 	}
 	if (crosshair)
 	{
-		for (u32 i = 0; i < config::CrosshairColor.size(); i++)
+		for (size_t i = 0; i < vmuTextures.size(); i++)


ok, i am sorry, I p-ut it back

nexus382 · 2025-02-27T07:10:38Z

core/rend/dx11/dx11_overlay.cpp

-			x /= config::ScreenStretching / 100.f;
+				float halfWidth = lightgun_crosshair_size / 2.f / config::ScreenStretching * 100.f * config::RenderResolution / 480.f;
+				float halfHeight = lightgun_crosshair_size / 2.f * config::RenderResolution / 480.f;
+				x /= config::ScreenStretching / 100.f;


understood, i will copy and move a bloc to another sheet, so when i revert i copy and paste back. or paste a few line s to undo my changes. so I am sorry, I am still learning, Ill watch spacing better.

nexus382 · 2025-02-27T07:28:25Z

core/rend/dx9/d3d_overlay.cpp

-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation, either version 2 of the License, or
-    (at your option) any later version.
+	Flycast is free software: you can redistribute it and/or modify


ok i think i did it
(after i commit the changes here in the PR, i dont think it is updating this view here, so i can not verify I made the proper changes. how can i refresh these to see if i fixed thoes issues?)

nexus382 · 2025-02-27T07:34:09Z

core/rend/dx9/d3d_overlay.cpp

 			drawQuad(rect, color);
+			if (config::OnlyShowVMUA1)


sorry, when i was trying to stpi the loop, i ende up in the wrong loop it seems.

nexus382 · 2025-02-27T16:17:21Z

core/rend/vulkan/overlay.cpp

@@ -129,8 +129,8 @@ void VulkanOverlay::Draw(vk::CommandBuffer commandBuffer, vk::Extent2D viewport,
 	{
 #ifndef LIBRETRO
 		f32 vmu_padding = 8.f * scaling;
-		f32 vmu_height = 32.f * scaling;
-		f32 vmu_width = 48.f * scaling;
+		f32 vmu_height = 70.f * scaling * config::VmuScreenSize;


This was because every VMU was handling the size change differently (they were all different sizes when going through the renderers), but this was done to help ensure all sizes and transparencies were the same across all the renderers with the sizing and transparency features. It's not like this VMU is larger when set to normal size (1x), but if you REALLY insist, I can change it back. I just fear it will break the uniformity again. From what I see, nothing has really changed from the inital sizing, but like I said, I can do it if we need to.

nexus382 · 2025-02-27T16:21:57Z

core/types.h

@@ -162,6 +162,7 @@ struct settings_t
 		float refreshRate = 0;
 		float dpi = 96.f;
 		float uiScale = 1.f;
+


nexus382 · 2025-02-27T23:46:59Z

ok. im sorry, this is a bit of a learning curve. I will be mindful when I copy and paste blocks and lines back and forth when undoing changes, that I do not mess up spacing. I never had that issue brought to my attention before, becasue I have never done anything like this before. This whole process is brand new to me lol. it will be better next time.

flyinghead · 2025-03-02T15:40:24Z

shell/libretro/option.cpp

@@ -3,151 +3,152 @@

 	This file is part of Flycast.

-    Flycast is free software: you can redistribute it and/or modify


Unnecessary white space changes. Please fix.

flyinghead · 2025-03-02T15:42:45Z

shell/libretro/option.cpp

+	Option<int> ScreenStretching("", 100);
+	Option<bool> Fog(CORE_OPTION_NAME "_fog", true);
+	Option<bool> FloatVMUs("");
+	Option<bool> OnlyShowVMUA1(CORE_OPTION_NAME "_only_show_vmu_a1", false);


This option isn't exposed in the libretro core (and it's not needed) so it's better to not give it an setting name:

Option<bool> OnlyShowVMUA1("");

flyinghead · 2025-03-02T15:43:24Z

core/rend/dx11/dx11_overlay.cpp

 		}
 	}
 	if (crosshair)
-	{


Unnecessary white space changes

white space changes still there

flyinghead · 2025-03-02T15:45:28Z

core/rend/dx9/d3d_overlay.cpp

-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation, either version 2 of the License, or
-    (at your option) any later version.
+	Flycast is free software: you can redistribute it and/or modify


This view shows all commits but you haven't fixed this part.

flyinghead · 2025-03-02T15:54:20Z

core/rend/gles/gldraw.cpp

@@ -8,6 +8,9 @@
 #ifdef LIBRETRO
 #include "postprocess.h"
 #include "vmu_xhair.h"
+// Add these global variables for the libretro build


These are constants and should be marked constexpr. And they don't need to be defined globally. Move these to where they are used (drawVmuTexture() in the #ifdef LIBRETRO section)

flyinghead · 2025-03-02T15:54:50Z

core/rend/gles/gldraw.cpp

@@ -121,7 +124,7 @@ static TileClipping setTileClip(u32 tileclip, int clip_rect[4])
 }

 template <u32 Type, bool SortingEnabled>
-void SetGPState(const PolyParam* gp,u32 cflip=0)


tons and tons of unnecessary white space changes. Please fix.

still valid

flyinghead · 2025-03-02T15:58:29Z

core/rend/vulkan/overlay.cpp

@@ -129,8 +129,8 @@ void VulkanOverlay::Draw(vk::CommandBuffer commandBuffer, vk::Extent2D viewport,
 	{
 #ifndef LIBRETRO
 		f32 vmu_padding = 8.f * scaling;
-		f32 vmu_height = 32.f * scaling;
-		f32 vmu_width = 48.f * scaling;
+		f32 vmu_height = 70.f * scaling * config::VmuScreenSize;


I don't see how more that doubling the VMU size can result in no visible size change at all.

ok I believe that is all back to normal for the White space changes . I have learned this lesson, and have been very acarefull in the current work im doing to avoid this. Thank you for being paitent.

fixed all white space changes

removed core option name

fixewd white space changes.

restored original size.

nexus382

ok. Again, I am still learning. I would be doing this better if there was a way to do the following, i am sure there is i jsut do not know...

When i come back thru, lets say, to fixe the white space changes, adn i edit and submit the changes right here one at a time, then i do one final "REVIEW CHANGES" is there any way to see on the compariison page, where its showing the old and the new side by side, with your comments, that i can get that page to update, to ENSURE its all done right and matching? after I make the changes and comment back, they main comparison screen will NOT reflect thoes chages. this will ensure I can verify i have done everything in less back and forths with us taking more of your time. I am still learning, sorry.

nexus382 · 2025-03-02T19:22:09Z

core/ui/gui.cpp

@@ -2294,78 +2303,113 @@ static void gui_settings_video()
        	resLabels[i] += " (" + scalingsText[i] + ")";
        }

-        ImGui::PushItemWidth(ImGui::CalcItemWidth() - innerSpacing * 2.0f - ImGui::GetFrameHeight() * 2.0f);


ok, I think I got these. I wish there was a way to SEE the changes im submitting in this view, to ensure with out you having to check and resubmit the issues.

will be much more careful in future about this. i found out when i copy and paste a block , i had it set to tbs, where flycast is mixed tab/space, so things goofed up. I have resolved this .

REMOVED CROSSHAIR LINE, AND FIXED WHITE PSCAE

nexus382

found moer fixes i didnt see needed

okr emoves the global variables from the top of the file Adds them as constexpr locals in the drawVmuTexture() function under the LIBRETRO section

core/rend/vulkan/overlay.cpp

re added, i might have accidently not put these back in but libretro had its own sizing and locations.

accidently removed and readded last line

fixed white space

white space changes

nexus382

All set I believe.

Added Ability to Resize, Change transparency, Show only 1st slot VMU …

6ad179c

…on screen, and move VMU window in DX 11 renderer

nexus382 force-pushed the vmu-screen-optimizations branch from 435be2f to 6ad179c Compare February 26, 2025 01:30

cleanup files

0147cc8

nexus382 force-pushed the vmu-screen-optimizations branch from cc10011 to 0147cc8 Compare February 26, 2025 04:17

flyinghead requested changes Feb 26, 2025

View reviewed changes

nexus382 and others added 10 commits February 26, 2025 11:47

push libretro

f5c7191

fix libretro

3b01230

fix libretro

1b628df

fix libretro

91417bf

Update dx11_overlay.h

fe22781

ok reverted code back.

Update dx11_overlay.cpp

de28e42

rmoved extra blocks out of the file. I think i fixed ym spacing issues.i obviously messed up when copying the original blocks back over when diagonosing issues, and then paste my corrected blocks... so i willtry to be mroe careful with the spacing issues.

Update d3d_overlay.cpp

fb2e159

spacing and bit fixes

Update d3d_overlay.cpp

d136f4b

removed crosshair imposter

Update overlay.cpp

dff2bf3

removed final break in crosshairs section

Update types.h

8f4ce58

removed whitepspcae change

nexus382 commented Feb 27, 2025

View reviewed changes

nexus382 requested a review from flyinghead February 27, 2025 23:45

flyinghead requested changes Mar 2, 2025

View reviewed changes

nexus382 added 5 commits March 2, 2025 14:20

Update gui.cpp

6b453ef

ok I believe that is all back to normal for the White space changes . I have learned this lesson, and have been very acarefull in the current work im doing to avoid this. Thank you for being paitent.

Update option.cpp

63fe2e7

fixed all white space changes

Update option.cpp

3e7ec4b

removed core option name

Update d3d_overlay.cpp

09f62d3

fixewd white space changes.

Update overlay.cpp

e6724ba

restored original size.

nexus382 commented Mar 2, 2025

View reviewed changes

Update gldraw.cpp

84a8c95

REMOVED CROSSHAIR LINE, AND FIXED WHITE PSCAE

nexus382 commented Mar 3, 2025

View reviewed changes

Update gldraw.cpp

e6f91ca

okr emoves the global variables from the top of the file Adds them as constexpr locals in the drawVmuTexture() function under the LIBRETRO section

flyinghead reviewed Mar 7, 2025

View reviewed changes

core/rend/vulkan/overlay.cpp Show resolved Hide resolved

nexus382 and others added 5 commits March 7, 2025 18:58

Update overlay.cpp

c4f8423

re added, i might have accidently not put these back in but libretro had its own sizing and locations.

Spacing fixes

e0c2b1d

Update d3d_overlay.h

7d5bd8f

accidently removed and readded last line

Update option.cpp

9e9c20a

fixed white space

Update gui.cpp

56693d8

white space changes

nexus382 commented Mar 8, 2025

View reviewed changes

		deviceContext->OMSetBlendState(blendStates.getState(true, 8, 8), blend_factor, 0xffffffff);
		// Get current mouse position

		drawGunCrosshair(i, width, height);
		if (config::OnlyShowVMUA1)

		@@ -3,151 +3,152 @@

		This file is part of Flycast.

		Flycast is free software: you can redistribute it and/or modify

Vmu screen optimizations #1858

Are you sure you want to change the base?

Vmu screen optimizations #1858

Conversation

nexus382 commented Feb 24, 2025

flyinghead commented Feb 25, 2025

nexus382 commented Feb 25, 2025

nexus382 commented Feb 26, 2025

flyinghead left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nexus382 Feb 27, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nexus382 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nexus382 Feb 27, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nexus382 commented Feb 27, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nexus382 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nexus382 left a comment

Choose a reason for hiding this comment

nexus382 left a comment

Choose a reason for hiding this comment

nexus382 Feb 27, 2025 •

edited

Loading

nexus382 Feb 27, 2025 •

edited

Loading