Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite to support rxdart 0.23.1 #34

Closed
dalewking opened this issue Dec 15, 2019 · 3 comments
Closed

Rewrite to support rxdart 0.23.1 #34

dalewking opened this issue Dec 15, 2019 · 3 comments

Comments

@dalewking
Copy link

Rxdart 0.23.1 is a major change and eliminates the Observable class.

@dalewking
Copy link
Author

Actually it was pretty easy to convert using https://pub.dev/packages/rxdart_codemod, Afterword, I think you only need to:

  • import rxdart into RxCommandListener
  • make RxCommand extend Stream instead of Observable
  • do not call superclass constructor in RxCommand
  • Add this method to RxCommand:
  @override
  StreamSubscription<TResult> listen(void onData(TResult event),
          {Function onError, void onDone(), bool cancelOnError}) =>
      _resultsSubject.listen(onData, onError: onError, onDone: onDone, cancelOnError: cancelOnError);

Haven't tested it yet. I'll see if I can whip up a PR for it.

@escamoteur
Copy link
Collaborator

It's on my todo list :-) a PR would be great.

@escamoteur
Copy link
Collaborator

Done with new Version 5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants