-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create WebviewRect in order to decouple the Webview from the Scaffold #567
Open
ivanasen
wants to merge
284
commits into
fluttercommunity:master
Choose a base branch
from
ivanasen:webview-rect
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing commented code; Using withZoom and hidden values; Verifying WebView instance before "navigate", "evalJavascript", "resize" and "closeWebView".
Using WKWebView instead of UIWebView
Added reloading (Android)
Added reloading (Android)
Added reloading (Android)
Never set minSdk and targetSdk in manifest.
Taking safe areas into account for bottom bars
Allow local files on iOs > 9.0
Added reloading (Android)
Fixed clearing cookies for ios
…headers Reload webview headers, ios clear cookies
update example for onPostMessage
bugfix: Added google() repository to allprojects to satisfy androidx build rules
Fix iOS local URL support (fixes fluttercommunity#114)
…l-dart Add JavascriptChannel abstraction in dart code
fixed min sdk for android
Prepare for release 0.3.8
This reverts commit b2104ab
Listen javascript function from flutter
Fix master branch
* added initial test support * added travis setup * modified tests * test new travis script * added tests for android * added android unit test support * upgraded script * fixed typo * added execute permissions * configured gradle * configured github actions * updated github actions * added andorid ut * added android yml * renamed files and tasks * removed redundant name * renamed tasks * fixed andorid ut script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may not always want to use the built-in Material Scaffold and want to use their own one, or have the WebView placed in custom-sized and positioned place on the screen.
So I separated the logic which draws the native webview over a custom rectangle in a separate widget.