Fixed pop the wrong page when changing the speed and added support for multiple resolutions #867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Fixed pop the wrong page when changing the speed
Issue: #618
2. Added support for multiple resolutions
Issue: #852
Now, to be able to change the video resolution, you need to pass the following parameters to the
ChewieController
:allowQualityChanging: true
The key can be any string that you want to display in the list of resolutions in the player. The value should be link to the video of this resolution.
Also, in order to be able to change the video resolution, I need to redefine the
videoPlayerController
inside theChiewieController
. Therefore, theonVideoControllerChange
callback has been added, which will allow you to get a new controller when it is replaced.The quality change has been added for iOS and Android only.