ci(analysis): using flutter analyze and checking correct formatting (#…

…107)

* ci(analysis): using `flutter analyze` and failing on warnings

* using `flutter analyze` for  analysis and added step for check if formatted properly

* [analysis] disable `secure_pubspec_urls`

* formatting

.github/workflows/analysis.yml

@@ -5,10 +5,21 @@ jobs:
   package-analysis:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2 # required
-      - uses: axel-op/dart-package-analyzer@v3
-        with:
-          # Required:
-          githubToken: ${{ secrets.GITHUB_TOKEN }}
-          # Optional:
-          #relativePath: packages/mypackage/
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Setup Flutter
+        uses: subosito/flutter-action@v1
+
+      - name: Install dependencies
+        run: |
+          flutter pub get
+          (cd demo && flutter pub get)
+
+      - name: Analyze Dart
+        run: flutter analyze . --fatal-infos
+
+      - name: Validate Dart formatting
+        run: |
+          flutter format .
+          ./.github/workflows/scripts/validate-formatting.sh

.github/workflows/scripts/validate-formatting.sh

@@ -0,0 +1,30 @@
+#!/bin/bash
+if [[ $(git ls-files --modified) ]]; then
+  echo ""
+  echo ""
+  echo "These files are not formatted correctly:"
+  for f in $(git ls-files --modified); do
+    echo ""
+    echo ""
+    echo "-----------------------------------------------------------------"
+    echo "$f"
+    echo "-----------------------------------------------------------------"
+    echo ""
+    git --no-pager diff --unified=0 --minimal $f
+    echo ""
+    echo "-----------------------------------------------------------------"
+    echo ""
+    echo ""
+  done
+  if [[ $GITHUB_WORKFLOW ]]; then
+    git checkout . > /dev/null 2>&1
+  fi
+  echo ""
+  echo "❌ Some files are incorrectly formatted, see above output."
+  echo ""
+  echo "To fix these locally, run: 'flutter format .'."
+  exit 1
+else
+  echo ""
+  echo "✅ All files are formatted correctly."
+fi

analysis_options.yaml

@@ -29,7 +29,8 @@ linter:
     - slash_for_doc_comments
     # pub related: https://dart.dev/tools/linter-rules#pub-rules
     - depend_on_referenced_packages
-    - secure_pubspec_urls
+    # TODO: this is currently not available in flutter-stable, uncomment once available
+    #- secure_pubspec_urls
     # import related
     - always_use_package_imports
     - implementation_imports

lib/src/app_bar.dart

@@ -8,7 +8,7 @@ import 'package:flutter/services.dart';
 /// functionality.
 ///
 /// It is internally implemented using the [AppBar] class. What differs from
-/// the [AppBar] implementation is the behaviour of [leading], 
+/// the [AppBar] implementation is the behaviour of [leading],
 /// [automaticallyImplyLeading] and [elevation].
 ///
 /// Usage example: