feat(fluent-bit): ServiceMonitor path values #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sébastien Larivière <sebastien.lariviere@goto.com>
slariviere
requested review from
edsiper,
naseemkullah and
stevehipwell
as code owners
|
@slariviere have you tested the Grafana dashboard with v2 metrics? I'd be keener to set v2 as default if the dashboard worked correctly. |
|
@stevehipwell the Grafana dashboard still works with v2 metrics. It mostly adds the storage API metrics and other metrics as I can see. |
Signed-off-by: Sébastien Larivière <sebastien.lariviere@goto.com>
|
@slariviere I think this change is worth a minor version bump. Could you also update the chart changelog annotations. |
Signed-off-by: Sébastien Larivière <sebastien.lariviere@goto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sébastien Larivière sebastien.lariviere@goto.com
Keeps the path to
v1by default, but allows it to be updated tov2if needed.