test_output_as_buffered_retries: fix flaky test #4877
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #4873
What this PR does / why we need it:
Before invoke
@num_errors_metrics.inc
, thedoes retries correctly when #try_write fails
test will be failed if thread will be switched atfluentd/lib/fluent/plugin/output.rb
Lines 1313 to 1315 in f34a253
It is easy to reproduce by adding
sleep
just before@num_errors_metrics.inc
, like:This patch will wait until
@num_errors_metrics.inc
is invoked.Docs Changes:
Release Note: