http input layer: parser realloc fixes (#9970) #9971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When buffer reallocation occurs in HTTP/1.1 connections, parsed header references become invalid since they point to locations in the old buffer. This causes memory corruption and crashes when later accessing those headers. Add splunk_conn_realloc_and_reparse() function that: - Performs buffer reallocation - Resets parser state - Reinitializes HTTP session and request This ensures no dangling pointers exist after reallocation, preventing crashes at the cost of reparsing. A proper fix using offsets instead of pointers will be implemented in mk_http_parser in a future change. Fixes #9964 Signed-off-by: Jorge Niedbalski <jnr@metaklass.org>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
…trics Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
requested review from
leonardo-albertovich,
fujimotos and
koleini
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #9970
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.