[fix] Fixed a DNS record encoding bug from the last commit

flomesh-io · Jul 31, 2024 · b820bc4 · b820bc4
1 parent e4404bf
commit b820bc4
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/api/dns.cpp b/src/api/dns.cpp
@@ -765,6 +765,7 @@ static int write_record(pjs::Object *dns, Data::Builder &db) {
     if (!utils::get_ip_v4(rdata, ip)) {
       throw std::runtime_error("invalid IPv4 notation");
     }
+    skip += push_int16(db, sizeof(ip));
     db.push(ip, sizeof(ip));
     skip += sizeof(ip);
   } else if (type == int(RecordType::TYPE_AAAA)) {
@@ -776,6 +777,7 @@ static int write_record(pjs::Object *dns, Data::Builder &db) {
     if (!utils::get_ip_v6(*rdata, ip)) {
       throw std::runtime_error("invalid IPv6 notation");
     }
+    skip += push_int16(db, sizeof(ip));
     db.push(ip, sizeof(ip));
     skip += sizeof(ip);
   } else if (type == int(RecordType::TYPE_SOA)) {