Custom Border Colors for Individual Windows #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flexagoon
requested changes
Jan 29, 2025
resources/schemas/org.gnome.shell.extensions.rounded-window-corners-reborn.gschema.xml
Outdated
Show resolved
Hide resolved
Comment on lines
-38
to
-42
| <key name="border-color" type="(dddd)"> | ||
| <summary>Border color for rounded corners window</summary> | ||
| <default>(0.5, 0.5, 0.5, 1.0)</default> | ||
| </key> | ||
|
|
There was a problem hiding this comment.
Since you're removing a schema key, you have to also bump the version and reset it in src/utils/settings.ts resetOutdated function
There was a problem hiding this comment.
Hi, can i ask for some clarification on this?
I have found the settings-version key, but it is set to 0 by default. I can also see that the last version is 7, but where is this being set and where do i bump it?
And further, in the resetOutdated() function, would it be enough to just add in prefs.reset('border-color')?
|
Also, please lint your code with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested in #60
Moved the border color property into custom/global settings instead of raw prefs, allowing it to be different for seperate windows