Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded corners reapear when minimizing and maximazing window with Dash to Dock #79

Open
Kartoffelbauer opened this issue Feb 5, 2025 · 1 comment

Comments

@Kartoffelbauer
Copy link

Kartoffelbauer commented Feb 5, 2025

When minimizing a maximized window to the dock and then maximizing it again (by clicking the icon on the Dock) the rounded corners will reappear, even to the window is still maximized. Keep Corners for maximality window is disabled.

This also seems only happening to none libadwaita apps like Firefox for example.
Also this only happens when the window was not opend in a maximized state.

Copy link

dosubot bot commented Feb 5, 2025

Hey @Kartoffelbauer! I'm here to help you with any bugs, questions, or contributions you might have. Let's tackle this together!

I found a similar closed issue regarding unexpected rounded corners when a window is maximized, but no solution was found in the comments [1].

In the code, the logic for applying or removing rounded corners based on window state is handled by the shouldEnableEffect function in src/manager/utils.ts. This function checks if the window is maximized and whether the setting to keep rounded corners for maximized windows is enabled [2]. Since you mentioned that the "Keep Corners for maximality window" setting is disabled, the rounded corners should not appear when the window is maximized.

Additionally, the extension includes event listeners for window minimize and maximize actions, which manage the visibility of shadows and rounded corners effects [3][4]. However, there is no specific mention of interactions with the "Dash to Dock" extension in the available information. It might be worth investigating if "Dash to Dock" affects window state signals or behaviors that could lead to this issue.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant