-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cxx_cmd
which parallels cc_cmd
#144
Conversation
edffa0c
to
7c646bb
Compare
0920cb5
to
c0f0564
Compare
cxx_command
which parallels cc_command
cxx_cmd
which parallels cc_cmd
@stanhu Do you want to give this branch a try on your projects before I merge, to make sure I'm not breaking anything? |
@flavorjones Sure, I'm running a test with the re2 gem now. |
This attempts to launch all builds with flavorjones/mini_portile#144.
I tested locally, and the CI runs in mudge/re2#151 look good. The failures are due to not having |
@stanhu Thanks for testing! I'll get an RC out this week. |
Thanks! I created mudge/re2#153 to test.
Awesome, great idea. FYI @mudge |
v2.8.7.rc1 seems to work fine. |
@stanhu Thank you! The downstream integration tests are live, FYI: https://github.com/flavorjones/mini_portile/actions/runs/9324948020 |
v2.8.7 final is out. Thank you again! |
Add a
cxx_cmd
. Use it for configuring CMake, removing the logic added in #130 for host-specific binary detection.Related to #141.