Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document additions in Electron BaseApp #444

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

JakobDev
Copy link
Contributor

@JakobDev JakobDev commented Feb 7, 2024

This documents the new patch-desktop-filename script in the Electron BaseApp introduced in flathub/org.electronjs.Electron2.BaseApp#56. It also describes how to make the UnityLauncherAPI work.

Fell free to correct my wording, as English is not my native language.

docs/electron.rst Outdated Show resolved Hide resolved

To make it work in Flatpak, the App needs to :ref:`use the correct desktop filename <use-correct-desktop-filename>`. The Flatpak also need the ``--talk-name=com.canonical.Unity``.

Electron checks `checks if it's running on Unity or KDE <https://github.com/electron/electron/blob/fb88375ab4d2161dbf7e958a2a94c7c6d97dc84c/shell/browser/linux/unity_service.cc#L64>`_ before using the UnityLauncherAPI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linkcheck doesn't like this link... not sure how best to resolve that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there maybe a way to whitelist this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not done it but maybe you can set linkcheck_ignore = ['...'] in conf.py.

https://www.sphinx-doc.org/en/master/_modules/sphinx/builders/linkcheck.html

Copy link
Collaborator

@bbhtt bbhtt May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/electron.rst Outdated Show resolved Hide resolved
docs/electron.rst Outdated Show resolved Hide resolved
docs/electron.rst Outdated Show resolved Hide resolved
docs/electron.rst Outdated Show resolved Hide resolved
docs/electron.rst Outdated Show resolved Hide resolved
docs/electron.rst Outdated Show resolved Hide resolved
docs/electron.rst Outdated Show resolved Hide resolved
docs/electron.rst Outdated Show resolved Hide resolved
docs/electron.rst Outdated Show resolved Hide resolved
docs/electron.rst Outdated Show resolved Hide resolved
@JakobDev
Copy link
Contributor Author

The documentation is now updated. I have also discovered that XDG_CURRENT_DESKTOP=KDE is also needed sometimes.

docs/electron.rst Outdated Show resolved Hide resolved
docs/electron.rst Outdated Show resolved Hide resolved
@hfiguiere
Copy link
Contributor

The documentation is now updated. I have also discovered that XDG_CURRENT_DESKTOP=KDE is also needed sometimes.

what kind of broken thing is this?

@JakobDev
Copy link
Contributor Author

what kind of broken thing is this?

This is Electron

@hfiguiere
Copy link
Contributor

what kind of broken thing is this?

This is Electron

That was rhetorical.

@razzeee
Copy link
Collaborator

razzeee commented Apr 25, 2024

This patch now seems to be needed, if you want to have correct app Icons in notifications with the new gnome release. So documenting it would be nice.

@bbhtt
Copy link
Collaborator

bbhtt commented May 6, 2024

Squashed the Github commits, changed the commit message bit and added the links ignore thing.

@bbhtt bbhtt merged commit b6bbcbe into flatpak:master May 6, 2024
3 checks passed
bbhtt added a commit that referenced this pull request May 6, 2024
bbhtt added a commit that referenced this pull request May 6, 2024
bbhtt added a commit that referenced this pull request May 6, 2024
bbhtt added a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants