-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document additions in Electron BaseApp #444
Conversation
|
||
To make it work in Flatpak, the App needs to :ref:`use the correct desktop filename <use-correct-desktop-filename>`. The Flatpak also need the ``--talk-name=com.canonical.Unity``. | ||
|
||
Electron checks `checks if it's running on Unity or KDE <https://github.com/electron/electron/blob/fb88375ab4d2161dbf7e958a2a94c7c6d97dc84c/shell/browser/linux/unity_service.cc#L64>`_ before using the UnityLauncherAPI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linkcheck doesn't like this link... not sure how best to resolve that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there maybe a way to whitelist this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not done it but maybe you can set linkcheck_ignore = ['...']
in conf.py
.
https://www.sphinx-doc.org/en/master/_modules/sphinx/builders/linkcheck.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation is now updated. I have also discovered that |
what kind of broken thing is this? |
This is Electron |
That was rhetorical. |
This patch now seems to be needed, if you want to have correct app Icons in notifications with the new gnome release. So documenting it would be nice. |
Squashed the Github commits, changed the commit message bit and added the links ignore thing. |
This documents the new
patch-desktop-filename
script in the Electron BaseApp introduced in flathub/org.electronjs.Electron2.BaseApp#56. It also describes how to make the UnityLauncherAPI work.Fell free to correct my wording, as English is not my native language.