Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qol(reth-rbuilder): default to 0 on engine persistence settings #423

Merged
merged 1 commit into from
Feb 11, 2025
Merged

qol(reth-rbuilder): default to 0 on engine persistence settings #423

merged 1 commit into from
Feb 11, 2025

Conversation

rkrasiuk
Copy link
Contributor

📝 Summary

Default to 0 on engine persistence settings because this is how it's supposed to be used anyway.

@ryanschneider
Copy link
Contributor

So for added context, reth defaults to 2 for these values, but rbuilder should really default to 0 since it doesn't really work unless 0 even when in-process.

@ZanCorDX ZanCorDX merged commit b81e74e into flashbots:develop Feb 11, 2025
4 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/reth-rbuilder-default-to-0 branch February 12, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanschneider ryanschneider ryanschneider approved these changes

@dvush dvush Awaiting requested review from dvush dvush is a code owner

@ZanCorDX ZanCorDX Awaiting requested review from ZanCorDX ZanCorDX is a code owner

@ferranbt ferranbt Awaiting requested review from ferranbt ferranbt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkrasiuk @ryanschneider @ZanCorDX