Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove broken benchmark CI #422

Merged
merged 1 commit into from
Feb 11, 2025
Merged

remove broken benchmark CI #422

merged 1 commit into from
Feb 11, 2025

Conversation

metachris
Copy link
Contributor

📝 Summary

Benchmark in CI has been broken for a while:

  • Metrics were inaccurate and gave the wrong picture
  • Links stopped working a while ago

Because of these, nobody looks at them anymore since a while already. Better to remove them, and maybe re-add later on.


✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

Copy link
Contributor

@sukoneck sukoneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, appreciate the clean up. This was a good idea, let's come back to this at some point!

@metachris metachris merged commit 3049968 into develop Feb 11, 2025
4 checks passed
@metachris metachris deleted the remove-benchs branch February 11, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants